Wp-calypso: Horizon Site Editor: Can't exit the Site Editor

[ianstewart]

I expect this one may turn out to be just a small one to fix as things may have just got a bit out of sync. To reproduce …

• Create a site on Horizon with the site editor flag.
• Attempt to exit the site editor and go back to Calypso.

Here's what I see when I attempt to exit the Site Editor right now. My browser tab appears to be crashing here in Chrome MacOS.

[ianstewart]

Here's a gif …

[vindl]

The problem here is that we don't have similar Dotcom specific overrides for this button like we had for W icon. As a result it's attempting to navigate to wp-admin page within the iframe and that request is blocked.

The proper solution here should be:

• create a slot/fill in core that allows us to replace the default button
• use that slot to provide a Dotcom specific version of it that navigates back to Calypso dashboard instead of wp-admin

[david-szabo97]

create a slot/fill in core that allows us to replace the default button

Taking this one 🙂 (https://github.com/WordPress/gutenberg/pull/26846)

[vindl]

The core PR for this has been merged. Once 9.4 lands on edge sites we can proceed with a Dotcom specific override. One note - since both site editor and post editor use the same slot/fill, we should make sure to limit the fill application to just the site editor context.