Wp-calypso: Gutenboarding: login has visible box around it

Created on 3 Oct 2020  路  3Comments  路  Source: Automattic/wp-calypso

At /new flow when unauthenticated, login screen looks like this:

Screenshot 2020-10-03 at 12 19 42

It shouldn't have that box around it. Likely from some core component upgrade.

Since the login screen is not in production for existing customers (it's just internal now), this isn't urgent to fix.

cc @Automattic/team-calypso this is a good example of what kind of challenges using @wordpress/components brings to us: we should probably start doing more visual diff testing.

[Goal] New Onboarding [Type] Bug

Most helpful comment

I'd bet with my dinner that we broke this with #45577.

All 3 comments

Oddly, the <fieldset> element is the one generating the visual border, and it's not from any additional styles being added as far as I can tell as this element by default has this border and doesn't come from a @wordpress/components reference. It's found here.

This however doesn't explain why this suddenly started happening unless some styles were recently removed. Interested to know why/how this happened but will open a PR to fix this in the meantime.

I'd bet with my dinner that we broke this with #45577.

Thanks for wrangling a PR @tjcafferkey and please do ping me for a review there 馃槈

Was this page helpful?
0 / 5 - 0 ratings