Wp-calypso: Seedlet: Custom link colors not rendered on frontend

Created on 8 Sep 2020  路  9Comments  路  Source: Automattic/wp-calypso

Steps to reproduce

  1. Activate Seedlet on a Simple site
  2. Open the block editor and write a paragraph with a link.
  3. From the block controls, expand color settings and change the link color.
  4. Publish the post and view it on the site (example post: paqfU8-tn-p2)
  5. The link color will not be rendered on the frontent.

Note that custom background and text colors (rendered as background-color and color in a style attribute) are respected. The custom link color is not.

cc: @jeffikus

What I expected

Render the link color.

What happened instead

The link color is not respected.

Screenshot / Video

It _says_ "green" but the link _should be #ff00ff "pink".

Editor

Screen Shot 2020-09-08 at 12 53 00
Screen Shot 2020-09-08 at 12 52 36

Frontend

Screen Shot 2020-09-08 at 12 51 33

Screen Shot 2020-09-08 at 12 51 44

Context / Source

[Goal] Gutenberg [Pri] Low [Type] Bug

Most helpful comment

I can't speak for dotcom but, for core, we're going to revisit how to fix this (see comment).

All 9 comments

I could repro this issue in a dotorg setup with an author role, see https://github.com/WordPress/gutenberg/issues/25151 In dotcom, I experienced this by testing with an admin role.

@sirreal @scruffian Got a potential fix for this at https://github.com/WordPress/gutenberg/pull/25411 Note, however, what I reported above: it looks like dotcom may be doing additional things to what core does, so it's worth looking into that separately.

Ah, it'd be great if you have a way to report whether the fix works for dotcom as it is.

Ah, it'd be great if you have a way to report whether the fix works for dotcom as it is

@nosolosw, I installed the build from https://github.com/WordPress/gutenberg/pull/25411 in D50012-code & tested in on my side but it doesn't seem like this patch alone fixes the issue:

| Editor | Preview |
| ------------- | ------------- |
| Screenshot 2020-09-22 at 15 46 59 | Screenshot 2020-09-22 at 15 47 09 |

@nosolosw has there been any follow-up regarding this issue on dotcom? This seems to be still happening.

I can't speak for dotcom but, for core, we're going to revisit how to fix this (see comment).

has there been any follow-up regarding this issue on dotcom? This seems to be still happening.

Context: There was a Seedlet theme update, which is why we revisited 馃檪

Let's revisit this when 9.2 lands.

Just confirming that this is still an issue in wpcom with Seedlet theme activated.

In the editor, with a custom link color set (to red):

image

In the front end:

image

Was this page helpful?
0 / 5 - 0 ratings