Wp-calypso: Gutenboarding: topbar has preview, update, launch options. We need to get rid of "Update".

Created on 22 May 2020  路  6Comments  路  Source: Automattic/wp-calypso

We don't need update

Screen Shot on 2020-05-22 at 12-47-27

Editor [Goal] New Onboarding [Status] Blocked / Hold

Most helpful comment

I threw up https://github.com/Automattic/wp-calypso/pull/42608 without much regard to the consequences.

I'm closing that PR until we come up with a way to address the UX deficit .

Thanks for the input!

All 6 comments

I'm confused about not needing update. I might be missing some extra context about a new save feature that's coming. Is there a link to some discussion?

  1. Land on home page editor after /new flow
  2. Make changes to the lorem text, I won't want to launch that
  3. Can't find way to save doc
  4. Click (W), get unsaved work prompt

    • Will lose work if I click OK

    • Stuck in a loop if I click Cancel

@ramonjd

I agree, we shouldn't just remove it.

Until the site is launched, we should either:

  • Rename it to "Save" (I know previous attempt failed)
  • Remove it and have the document save continuously, no separate saving needed.

I threw up https://github.com/Automattic/wp-calypso/pull/42608 without much regard to the consequences.

I'm closing that PR until we come up with a way to address the UX deficit .

Thanks for the input!

Sorry, I should have added more context to issue.

The action saves the doc. Update feels incorrect. We should relabel to "Save".

Rename it to "Save" (I know previous attempt failed)

What failed?

Rename it to "Save" (I know previous attempt failed)

(I think) React had a major hissy fit when it couldn't reconcile what it considered to be the right DOM node tree.

We messed around with a text node, and when it couldn't find it, it threw its toys in the corner and went home, which is a metaphor for throwing an exception and borking the whole site.

https://github.com/Automattic/wp-calypso/pull/42508

Placing on hold until we work out what the best solution would be here.

We can't mess with the text area (See: #42508).

Adding a button is possible (and therefore hiding the existing), we do this with Launch, but there's a move to relocate that to FSE and it seems like an overkill.

Was this page helpful?
0 / 5 - 0 ratings