Wp-calypso: Remove Google Plus

[mdawaffe]

The API for third party access to Google+ has been shut down. The service as a whole will shut down in April.

The Publicize APIs no longer return information about the Google+ Service or any Google+ Connections, so I believe it's the case that Publicize: Google+ has been removed everywhere from the visible UI.

We can remove any Google+ code, especially including the recent deprecation notices:

• #29370
• #30415

@eliorivero, what else am I missing?

Depending on how it's implemented, sharing to Google+ (via post sharing buttons) may still work, but we've removed that from WordPress.com and Jetpack already as well. I'm not sure if sharing to Google+ from the reader is possible, but the Sharing Buttons settings UI offers a Google+ button, which should be removed. See, for example, https://github.com/Automattic/jetpack/pull/11200.

[richardeschloss]

Just a small question...I know probably should look at the code before asking but, it might be quicker to ask here, and easier for future readers of this thread...is there any old oauth code that uses "sign on with Google"? I think an old way of signing on with Google used the google+ apis, but now the new way Google wants clients to connect is: [your_client_id].apps.googleusercontent.com

[mdawaffe]

Thanks for bringing that up, @richardeschloss. I don't know the answer :)

I do know there are other Google services we connect to (Google Photos, for example), but I believe they all authenticate through their own, more specifically scoped, auth channels.

[eliorivero]

That's all on Calypso, although there are still some elements in Jetpack that must be removed like
https://github.com/Automattic/jetpack/blob/master/modules/widgets/customizer-utils.js#L38
or
https://github.com/Automattic/jetpack/blob/master/modules/widgets/social-media-icons.php#L79

[simison]

@mdawaffe @eliorivero Should any Google+ related stuff from Publicize-Gutenberg sidebar be removed before code freeze for the April release?

[mdawaffe]

@mdawaffe @eliorivero Should any Google+ related stuff from Publicize-Gutenberg sidebar be removed before code freeze for the April release?

I'm not sure what all is there :) If it's just the conditional stuff, it doesn't matter too much, but, yes, it'd be nice if everything were gone.

[simison]

Publicize-Gutenberg sidebar

There's this notice visible for users with Google+ connections:

https://github.com/Automattic/wp-calypso/blob/9c7f23f92dce5445e0e15b77eb5aa4799f5c600b/packages/jetpack-blocks/src/blocks/publicize/connection.jsx#L37-L57

I don't know if it shows up after any possible backend code is removed.

Notice says:

Google+ will shut down in April 2019. You can keep posting with your existing Google+ connection through March.

...so I'd say this should be removed.

Also these bits and bobs:
https://github.com/Automattic/wp-calypso/blob/9c7f23f92dce5445e0e15b77eb5aa4799f5c600b/packages/jetpack-blocks/src/blocks/publicize/service-icon.jsx#L45
https://github.com/Automattic/wp-calypso/blob/9c7f23f92dce5445e0e15b77eb5aa4799f5c600b/packages/jetpack-blocks/src/blocks/publicize/editor.scss#L44-L46

And that CSS variable is here and there: https://github.com/Automattic/wp-calypso/search?q=--color-gplus&unscoped_q=--color-gplus

cc @flootr

[mdawaffe]

I don't know if it shows up after any possible backend code is removed.

It shouldn't show up anymore. It should be removed.

The other stuff can be removed as long as nothing else uses it. (Google Photos?)

[arunsathiya]

I came across Google+ preview option on re-Publicize section for a WordPress.com Premium plan+ site and I have logged it here https://github.com/Automattic/wp-calypso/issues/32105

Feel free to close if the current tracker can be used for it instead.

[simison]

I came across Google+ preview option on re-Publicize section for a WordPress.com Premium plan+ site and I have logged it here #32105

Addressed in https://github.com/Automattic/wp-calypso/pull/32503