Wp-calypso: Publish package: `lib/simple-payments`

[simison]

Used by simple payments block here:

https://github.com/Automattic/wp-calypso/blob/241292989efa898345417b4632f6402605497895/client/gutenberg/extensions/simple-payments/edit.js#L27

Packaging docs:
https://github.com/Automattic/wp-calypso/blob/ce2493f7fcb3662d16dda09d8885620f0051728b/docs/monorepo.md#readme

After moval, test by running first npm run distclean && npm ci to ensure you have the new package in use.

[simison]

Is Simple payments code in Calypso classic editor going to be needed in Calypso once Gutenlypso is no more? Can we just move these files to the block folder itself:

From: /client/lib/simple-payments
To: client/gutenberg/extensions/simple-payments

...and bring them over to Jetpack and not have them in Calypso codebase?

@Automattic/lannister thoughts?

[simison]

Used only in tinymce plugin and related data-layer bits:

[gwwar]

There's still the Calypso Classic editor, so in terms of ordering we'd need to update usages until we complete a full editor rollout.

If this code is only used in the blocks, then we'll just need to make sure Gutenframe is stable, and that Gutenlypso code has been removed. Probably will happen this week.

Sound about right @rodrigoi ?

[sirreal]

There is some code that would be good to share so our Simple Payments experience is consistent:

• Supported currencies
• The custom post type slug

The de facto way at this time seems to be by publishing a package.

If the classic editor (and associated Simple Payments code) has a limited future in Calypso, it would be completely viable to duplicate the code for now and let it be cleaned up from Calypso.

p1551889885726100-slack-jetpack-gutenberg

[gwwar]

@sirreal Code duplication seems reasonable here to me, let's maybe just leave a comment note that they're not connected.

[sirreal]

We can let #31199 handle this.