Wp-calypso: Jetpack Writing settings: 1TB storage showing for videopress

[dougaitken]

Steps to reproduce

1. WordPress site connected to Jetpack with a Premium or Professional Plan
2. Start at https://wordpress.com/settings/writing/
3. Scroll to Media
4. Toggle Enable fast, ad-free video hosting on

What I expected

No mention of storage _limit_ as described in the Jetpack Premium or Professional plans.

What happened instead

When enabled, I see a 1TB limit on the video hosting with a sotrage size progress-type bar and an upgrade button. This upgrade button shows even on a Professional plan, this highest plan available on Jetpack.com.

Browser / OS version

N/A

Screenshot / Video

Image link: http://cld.wthms.co/47eXzf

Context / Source

manual-testing

I was checking another feature related to a ticket on the Writing screen in Calypso and notices the bar.

This doesn't show on the wp-admin/admin.php?page=jetpack#/settings for the same site so it is Calypso specific.

[sirreal]

cc: @jmdodd

[sirreal]

A starting point for folks looking at this is D5652-code and https://github.com/Automattic/wp-calypso/blob/2f2db040979e48885e342a09b68e49b5fb822b32/client/my-sites/site-settings/media-settings.jsx#L109-L120

[rfaile313]

I'd like to take a look at this if no one minds, I have a few ideas for how to fix.

[rfaile313]

@sirreal @dougaitken We've identified the problem and are discussing the best way to change this moving forward in p9F6qB-ww-p2 since it was a recent commit that changed this.

[rfaile313]

Outlined problem in depth in p9F6qB-ww-p2 and proposed solutions 😄

[sirreal]

Updating with investigation from @rfaile313, this is not my work, all props to @rfaile313:

This problem was likely introduced in D13199-code which increased the value used to represent unlimited storage plans. Existing sites do not seem to have been updated so when a comparison is made to check for unlimited storage, it now fails.

[stale[bot]]

This issue has been marked as stale and will be closed in seven days. This happened because:

• It has been inactive in the past 9 months.
• It isn't a project or a milestone, and hasn’t been labeled `[Pri] Blocker`, `[Pri] High`, `[Status] Keep Open`, or `OSS Citizen`.

You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation.

[arunsathiya]

@dougaitken I could be missing something, but the original report seems to be fixed now. I don't see 1TB limit anymore:

Could you confirm?

[dougaitken]

@arunsathiya my site doug.press is on a Professional Jetpack plan, on the same section you've screenshotted, my site shows 0% of 1 TB used