Wp-calypso: Typographical widow on the purchase confirmation screen

Created on 13 Jul 2018  Â·  6Comments  Â·  Source: Automattic/wp-calypso

image

A potential quick fix here would be just adding a nbsp; between "in" and "excitement."

Checkout [Status] Stale [Type] Bug

Most helpful comment

I just stumbled onto a widow helper funxction in calypso:
https://github.com/Automattic/wp-calypso/blob/master/client/lib/formatting/index.js#L56

All 6 comments

Does Calypso have a widont equivalent? To automate this like we do on WordPress.com.

Does Calypso have a widont equivalent? To automate this like we do on WordPress.com.

It does not look like it is the case.

A potential quick fix here would be just adding a nbsp; between "in" and "excitement."

That may introduce translation problems, since that is a string that will need to be translated.

I am not able to take care of this PR due to the fact that I really have my hands full with Memberships.

@Automattic/neutron - is this in Neutron's scope ?

Is there a reason we shouldn't use a tool like typogr.js? It has a widont filter built in. Then, we would have an easy way to fix these moving forward.

I just stumbled onto a widow helper funxction in calypso:
https://github.com/Automattic/wp-calypso/blob/master/client/lib/formatting/index.js#L56

Fix ready for testing in #26225

This issue has been marked as stale and will be closed in seven days. This happened because:

  • It has been inactive in the past 9 months.
  • It isn't a project or a milestone, and hasn’t been labeled `[Pri] Blocker`, `[Pri] High`, `[Status] Keep Open`, or `OSS Citizen`.

You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation.

Was this page helpful?
0 / 5 - 0 ratings