Wp-calypso: Activity: remove Jetpack Search banner on free sites

[keoshi]

Currently on free sites, the Activity section already has an update nudge.

We should conditionally display the banner Jetpack Search, so that it doesn't show up at the same time as existing Activity nudges.

[roccotripaldi]

This may be resolved now. I cannot get this banner to appear, nor can i find reference to it in the code.

[roccotripaldi]

I found it - the logic is not on calypso but on wpcom, working on a fix!

[gibrown]

This seems like it is a case where the two nudges are implemented differently. The JP Search one goes through JITMs which can only display one at a time. It looks like the activity log one does not use that same mechanism.

[roccotripaldi]

Good points @gibrown

We are limited on what we can do here by the fact that Activity Log is in the stats section, and this particular JITM is tied to the stats section.

A couple of ideas based on this limitation:

1) we could hide the Search banner for all free sites
2) we could move "Activity Log" to its own section

I'm not crazy about option 1, because it would stop us from showing off one of Jetpack's coolest features for free sites that could benefit from them.

Option 2 makes more sense. We've got a lot of push back to put Activity Log in its own section, and mobile is treating it as such.

With it's own section, the Activity Log could be free of stats-related banners, and have it's own JITM logic.

what do you think @keoshi

[keoshi]

I'm completely on board with option 2, but we should have at least these pieces in place for that to happen:

• Upgrade banners.
• Better publicly available documentation on retention. cc @annezazu Is this something you and I could tackle in the next few days?

[annezazu]

@keoshi I would loop in the expert @tmmbecker who runs our documentation efforts. Happy to help in whatever way needed to!

[keoshi]

Perfect, thank you so much! I'll ping you soon @tmmbecker

[roccotripaldi]

I will check with marketing this week to see how they feel about dropping this, and see if they have a suggested approach.

[roccotripaldi]

PR to hide on free sites: D17220-code

And a p2 post checking with marketing: p5uIfZ-8y9-p2

[roccotripaldi]

This should be fixed as of https://github.com/Automattic/wp-calypso/pull/26941