Wp-calypso: Activity: no rewind buttons after adding back credentials

Created on 10 Apr 2018  ·  2Comments  ·  Source: Automattic/wp-calypso

While testing the Activity log, I removed and added back credentials.

This seems to tell the UI that this site is just now being set up and originates a couple of problems:

  • No rewind buttons visible across the UI; they were there before.
  • “Backup underway” banner has incorrect copy: in this case we are _not_ backing up the site for the first time, and so this is not the initial backup. We should check and have different banners for different scenarios.

image

Rewind [Pri] Normal [Type] Bug

All 2 comments

This is because after re-entering creds, the Rewind state is provisioning. At this point, Rewind actions like restores and backups aren't available.

A quick fix for the notice is to update the copy so instead of "We're currently backing up your site for the first time" it says something simple like "We're creating a backup of your site".

However this should be addressed in the Rewind state machine and I wrote a post about it in p9rlnk-ei-activitylogrewind

@dmsnell fixed this in D11668

Was this page helpful?
0 / 5 - 0 ratings