Wp-calypso: Guided Tours: Jetpack connected sites starts guided tour

[brbrr]

Steps to reproduce

1. Connect new Jetpack site
2. After successful connect you will be redirected to WordPress.com and Guided tour would be started (?tour=main)

What I expected

the main tour is also never triggered anywhere — it's just for us to try things out
As @lsinger told me - Guided tours are disabled, So I expect not to see guided tours after connection.

What happened instead

I was redirected to https://wordpress.com/plans/my-plan/special-sumatran-231.jurassic.ninja?tour=main and Guided tour had started.

Browser / OS version

Chrome / MacOS

Screenshot / Video

Context / Source

automated-testing

[lsinger]

This was added in #22341 to provide a tour for Jetpack users. I missed it because it wasn't labeled Guided Tours (for which I have a Zap to monitor issues and PRs).

I think in spirit that makes sense, but we've been using the main tour as a playground for Guided Tours development. There were times where it was broken for weeks, but that was fine because it wasn't used in production.

I admit it isn't too obvious from the docs, but:

This tour shows a few important features of Calypso and is intended to help new users find their way around. In a test it performed worse than Trampoline, so it isn't currently being triggered. In the future, a combination of Trampoline and this tour could be considered. (Guided Tours README.md)

// note that this tour checks for a non-existent feature flag.
// this is kept as an example, while making sure it never gets triggered

(main tour's definition)

I'd prefer we remove this tour from the Jetpack connection flow and then create a more specific and better-named one (that we can of course base off of this one).

/cc @tyxla @ockham @sirreal

[tyxla]

Thanks for reporting this @brbrr and for the clarifications @lsinger. We didn't really realise that we're using an incorrect tour.

I'd prefer we remove this tour from the Jetpack connection flow and then create a more specific and better-named one (that we can of course base off of this one).

Sounds like a great plan and something I'd be happy to work on. We've been talking about a Jetpack-specific guided tour and it's probably a good time to work on that now.

cc @Automattic/jetpack-design and @rickybanister for some ideas on what to include in the guided tour. Should it be a replica of this one for starters?

[ockham]

I think in spirit that makes sense, but we've been using the main tour as a playground for Guided Tours development. There were times where it was broken for weeks, but that was fine because it wasn't used in production.

I admit it isn't too obvious from the docs, but: [...]

@lsinger Can we maybe rename it to experimental or __ugly_name or something? I actually _found_ it through client/layout/guided-tours/README.md, which says:

• [...] Such a tour could be triggered by certain user behavior, or could be linked to using a special URL (see e.g. https://wordpress.com/?tour=main).

and

List of Tours

• Main Tour: This tour shows a few important features of Calypso and is intended to help new users find their way around. In a test it performed worse than Trampoline, so it isn't currently being triggered. In the future, a combination of Trampoline and this tour could be considered. (URL scheme to trigger.)

so I guess docs should be updated as well to indicate we actually _don't_ want to trigger this tour?

[keoshi]

cc'ing @joanrho to see how this can play with the checklist you've been working on. Maybe we can build smaller guided tours for all/the most complex steps when onboarding someone.

[lsinger]

@ockham all valid concerns and ideas, definitely — that's why I said "I admit it isn't too obvious from the docs". 😬

[tyxla]

23441 duplicates the guided tour and updates the use case in the Jetpack Connect flow.

[ockham]

@lsinger We do the tour change (#23441), you do the doc fixes? 😁

[lsinger]

Opened a PR for the documentation fixes here: #23641.