Wp-calypso: Sharing: changes do not get saved if you toggle all of the "Show sharing buttons on" options from checked to unchecked [2]

[designsimply]

Steps to reproduce:

1. Go to My Sites > Sharing > Sharing buttons.
2. Find the "Options" section.
3. Uncheck everything under "Show sharing buttons on."
4. Click the "Save Changes" button.

Result: if you toggle all of the "Show sharing buttons on" options from checked to unchecked, changes do not get saved.

Video: 36s

^{Seen at https://wordpress.com/sharing/buttons/design5279.wordpress.com (production) using Firefox 58.0.2 on macOS 10.13.3.}

Aside: this bug is really strange, some combinations of saving changes work and some don't. (4m12s)

/hat tip 🤠 @cecoates because a related bug posted in the #triage channel led me to find this bug!

[nagpai]

I was able to replicate the issue on my test site too, with some of the buttons checked.

1050920-zen

[jamiepalatnik]

Reported in this chat: 2375165-hc

[katinthehatsite]

Also reported in #1091646-zen

[ebastos]

Another report via 4352362-hc

[julsyd]

User report 3957790-hc. I was able to reproduce on several test sites (Free and Premium plans).

[GeoJunkie]

User ran into issue in 5889561-hc

[kathrynwp]

Also encountered during a Business Concierge session. Ref 1561558-zen.

[kathrynwp]

Also reported in #29261

[tbradsha]

9221302-hc

[jamiepalatnik]

9438998-hc. Selecting Front Page, Archive Pages, and Search Results was not saving unless I selected Orders as well. Then it saved, but Order showed as unchecked.

[suyogyashukla]

9744174-hc

[Robertght]

Another one found here: #9753379-hc

[Robertght]

8291337-hc

[kylemcph]

9974040-hc

[sophiegyo]

Reporting as well, I encountered it here: 10448703-hc

My findings: it's specifically the post page which does this.
I tested on one of my own sites and was able to reproduce it.

Activating any/all options for sharing button display: no problem.
Deactivating any but Pages: no problem.
Deactivating several, including Pages: problem.
Deactivating Pages only: problem.

Screencast recordings:
https://cld.wthms.co/OxLSPO
https://cld.wthms.co/94OKxE

[chaitanyamsv]

Another report in #10599280-hc

[Robertght]

2097603-hc - Simple site. Hd to assign it to a Product again.

[desnum]

Another case in hc-10729527 with the Venture theme

[nagpai]

Another case in 9311829-hc

[damiannep]

Another case in #10845695-hc

Looks like you have to keep at least one option checked: https://cld.wthms.co/FzjyeY

[nickpagz]

Another case in #10285453-hc

[AtrumGeost]

Another case here 7740966-hc

[tijosh]

Another case in 1869218-zen where one option had to remain selected: https://cld.wthms.co/7Ot5wq

This was a simple site, so I tried _only_ selecting "Products", and then clicked Save Changes, and now none of them are checked.

[kristarella]

+2

• when I was working on the site johnmichaelwrightcom.wordpress.com
• also 11426727-hc had to use wp-admin to uncheck

[julsyd]

Another report in 1917390-zen.

I was able to get around it by unticking Posts and Pages, and ticking Orders, then saving. Since Orders aren't used on the site, it gets disabled when saving, and leaves Posts and Pages disabled as well.

[khristiansnyder]

Another report in 1915954-zen

They also think they have a fix:

The value for the pages and posts checkboxes (in the sharing_show[] array) are in their singular form (eg "page" instead of "pages"). The impact is that users can't turn those checkboxes off because it's submitting the wrong value.

Simply changing the checkbox value attribute to "pages" and "posts" (I've edited the html client-side to verify this) makes the Save Changes button actually update the database.

I can also replicate this on my test AT site: https://cld.wthms.co/5LVGBD
Has this gotten worse in the last few weeks? I'm noticing this issue consistently across many sites.

[kristarella]

Has this gotten worse in the last few weeks? I'm noticing this issue consistently across many sites.

I'm not sure it's gotten worse, I think it consistently affects all sites when trying to edit from Calypso, it's fine in WP Admin.

Taking @juliasydnor 's info into account, it might be related to how the info is being saved. Usually no check = no value so nothing needs to be saved, if changing which items are checked it is easy to save the new arrangement of values, but when they were previously checked, and then nothing is checked there needs to be an action taken, like if there is a value saved in the database, but no value is submitted now, delete the value in the database.

[TeniCola]

Another case in HC-11811878, where the settings for the sharing buttons did not save for the user's site, who wanted to untick the Posts and Pages options

I was able to replicate this in SU-mode, and I borrowed @juliasydnor's solution to tick the Order's option to save/resave until the Posts and Pages were unticked. Followed up with the user in ZD-1937724

[gwwar]

🤔 I think I can't unset options here.

cc @Automattic/lannister this one is up for grabs, let's get a fix out for related p1HpG7-6vu-p2 flows

[sophiegyo]

User in #12176243-hc reported the issue also occurs for them in Calypso (Block editor view) for individual posts/pages.

Their recording: https://screencast-o-matic.com/watch/cqfFlcZT5l

[thuautp]

User also reported this issue here #12702424-hc

[Copons]

@thuautp Thanks for reporting!

Apparently this has changed in the last few days after https://github.com/Automattic/jetpack/pull/12319 (and its twin diff D28007-code) got merged.

@jeherve Could you please clarify about this?
The change practically prevents people to unset all sharing buttons checks, because they will always fall back to [ 'post', 'page' ]

[tbradsha]

4839871-hc

[jeherve]

The change practically prevents people to unset all sharing buttons checks, because they will always fall back to [ 'post', 'page' ]

@Copons That's a good point, thank you, I hadn't thought about that use case.

Would you mind reviewing D28357-code or https://github.com/Automattic/jetpack/pull/12401, and let me know if that fixes the problem for you?

Thanks!