Wp-calypso: Activity Log: backup complete item should not be rewound

[keoshi]

When confirming a site restore the confirm dialog appears above the selected item, letting me know the site will be rewound to this point and all other items above will be discarded.

However, once the restore is complete, the initial “full backup” item is also marked as discarded:

EDIT: these two screenshots are not part of the same flow, just illustrating styling differences before and after a restore.

@eliorivero can you take a look, please?

[eliorivero]

Thanks for the report. Ok, we'll look into keeping the backup used for the rewind un-dismissed, as well as the the rewind success event.

[eliorivero]

Assigning @dmsnell since he's the better person to handle this issue in the server.

[dmsnell]

@keoshi is there any way you can share the site on which that was viewed? I would like to check the events themselves.

[eliorivero]

Provided required info to Dennis on Slack.

[dmsnell]

@keoshi is it possible to try again with that same event and see if the behavior remains? I'm asking because there were recent changes the may address this and I want to rule out the easy things if we can.

if you can't reproduce on this site then we will have to try and find ways to make this reproducible.

[dmsnell]

this is all too confusing.

I'm going to stop for the day but I suspect that what's happening is related to the way we butcher timestamps. the rewind_id is usually a string version of a timestamp with fractional seconds and I have seen precision down to ten-thousandths of a second. that is ss.SSSS if that makes sense.

therefore since we truncate the timestamp when calculating is_discarded to the ms then we may simply be ending with a 9-out-of-10 chance that the backup will appear discarded when it's not.

[dmsnell]

Hopefully related and hopefully resolving the issue: D10486

[eliorivero]

With discarded events out of the equation, we can now close this.