Wp-calypso: Jetpack Onboarding: Delete onboarding token after completion

[tyxla]

We generate the onboarding token to allow onboarding requests, but after onboarding has been completed, we probably want to delete the token because it will no longer be necessary.

We could do that immediately (currently supported in the Jetpack settings endpoint by providing the end parameter to the onboarding setting).

Another possible way is to clean the onboarding tokens automatically using a cron job (wp_schedule_event()).

Probably the best way to do it is upon successful Jetpack connection.

[ockham]

Probably the best way to do it is upon successful Jetpack connection.

I agree. However, if we move Jetpack connection to an earlier step, this will cause all other steps to stop working, won't it? :slightly_frowning_face:

[tyxla]

That's true 😞

Let's wait and see if we'll be moving the Jetpack Connection step at the beginning. If we decide to move it, we might have to implement something on the Jetpack side to delete the tokens after some period has passed after their last use. If we keep it at the end, we can probably do it in Calypso upon connection.

[ockham]

However, if we move Jetpack connection to an earlier step, this will cause all other steps to stop working, won't it? :slightly_frowning_face:

One more idea -- can we make the onboarding endpoint simply work when connected, i.e. authenticated through a "regular" JPC token?

[tyxla]

I like this idea, but it's separate from deleting the token, so opening a separate issue for it: #22578

[tyxla]

A solution for this one has been suggested in #22763 and https://github.com/Automattic/jetpack/pull/8933.