Wp-calypso: Signup: Themes cannot be purchased/activated in signup flow from logged out theme showcase

[rachelmcr]

Steps to reproduce

1. Starting at URL (logged out of WordPress.com): https://wordpress.com/theme/photo-blog (or any other premium theme)
2. Select "Pick this design" and complete the signup flow.

What I expected

I expected to be presented with a checkout page during signup to purchase the theme, so it's activated when signup is completed.

What happened instead

I never had a chance to purchase the theme, and my new site has a default theme (Twenty Sixteen) activated.

If you select the Free plan during signup, checkout is skipped entirely. If you select a paid plan, you get a checkout page but only the plan (not the theme) is in the cart.

Browser / OS version

Mac OS 10.12.6, Chrome 62.

Context / Source

manual-testing Found while retesting https://github.com/Automattic/wp-calypso/issues/8264

[rachelmcr]

@p3ob7o is this something your team could look into? Just want to make sure it doesn't slip through the cracks as it's impacting signup/checkout.

[designsimply]

Tested and confirmed using the steps provided.

Result: selecting "Pick this design" on a logged-out theme page does not result in an opportunity to purchase the selected theme or a plan including the theme.

Video: 1m7s

^{Starting here. Seen at https://wordpress.com/theme/photo-blog using Firefox 57.0.1 on Mac OS X 10.13.1 logged out.}

It's also worth noting that the theme selection step was completely skipped in this flow and that I saw some errors flash (but not for long) that made it seem like the account wasn't going to be created (even though it was).

Account username: user428
Account blog: madefortesting126.wordpress.com

[ockham]

Looks like this has been reported before: #20316 (almost 2 weeks ago! :slightly_frowning_face: )

[seear]

Seems like this was broken by #18557 in late October. That PR renamed the queryObject prop to initialContext without changing all uses of that prop, one of which is determining the chosen theme on signup.

[rachelmcr]

@hoverduck What do you think of adding a test for this (signup through /themes with a premium theme) to the e2e signup spec?

[hoverduck]

What do you think of adding a test for this (signup through /themes with a premium theme) to the e2e signup spec?

@rachelmcr Sounds like a good idea. I'm hesitant to add new tests that lengthen our test runtime, but anything involving purchases is probably important enough to go ahead with.

[seear]

Fix in #20746.

There is a separate, unrelated issue where it is not possible to purchase a theme at signup when purchasing a dotblog domain. This seems to be some kind of server-side cart issue, where even though Calypso is adding the theme to the cart using the cart API, the theme doesn't end up in the cart at checkout. The initial selection of a dotblog domain seems to add a premium plan to the cart on the server, which may have something to do with the theme not being properly added (all themes are free with the premium plan).

I can take a closer look at the dotblog issue later.

[ockham]

I tried to repro this. It fails, but for different reasons: after completing signup, I'm not logged into WP.com (and taken to my cart and checkout) but to the log-in form which asks me to verify my email address first.

[ockham]

The issue I'm seeing ^ might be unrelated to this one -- possibly due to different locale?

Although UI strings are displayed in English for me; I do get a note telling me 'Auch verfügbar in Deutsch' ('Also available in German') at Step 1 (domain selection).

[rachelmcr]

@ockham That could be related to the email address you used in testing (see internal ref: p58i-6Oi-p2).

[ockham]

I did use a work +throwaway email address. Good point @rachelmcr, didn't occur to me -- will test with a different one!

[seear]

20746 is now merged and fixes premium theme purchase and activation on signup with free and personal plans.

There are (at least) two remaining issues:

• Signup with a premium theme when purchasing a dot blog domain does not include the theme in the cart (this looks to me like an API/back-end cart problem)
• Premium themes are not activated when signing up with a premium plan or higher

My hunch is that neither of these issues is recent, or necessarily a Calypso problem. @rachelmcr should we create separate issues for these problems and assign them to appropriate theme or signup teams?

[designsimply]

My hunch is that neither of these issues is recent, or necessarily a Calypso problem. @rachelmcr should we create separate issues for these problems and assign them to appropriate theme or signup teams?

Yes, please!

Issues don't get assigned to specific themes (and these issues cross different areas such as NUX/Signup/Purchases/Themes) so labeling with the area of work that fits closest is the way to go.