Wp-calypso: Site settings: sync notification looks weird

Created on 30 Nov 2017  路  2Comments  路  Source: Automattic/wp-calypso

Steps to reproduce

  1. Starting at URL: https://wordpress.com/settings/manage-connection/:site (jetpack site)
  2. Let "Data synchronization" section load
  3. See "Last fully synced" notification

What I expected

This is how notification looked before PR https://github.com/Automattic/wp-calypso/pull/17796 _"Update notice colors to pass WCAG AA guidelines"_:

image

What happened instead

This is how it looks today:
image

Context / Source

Seems to boil down to the fact that there's some custom css modifying that sync notice.

See how Notices normally look like (choose "Compact Notices").

Checking out an issue about inline notice styles might be relevant.

/cc @jameskoster

Design Jetpack OSS Citizen Site Settings [Type] Bug

Most helpful comment

In my opinion, it probably shouldn't be a Notice. I haven't viewed the whole context of the page, but your suggestion to just use gray text seems good to me.

All 2 comments

I could send a quick PR to fix this.

Would regular just <p></p> suffice? Notice element doesn't seem to have any ARIA attributes that we'd be missing (tho it might have them in future).

If design change would be okay, a quick fix would be make it look like either one of these:

image

...or even like <FormSettingExplanation>:
image

In my opinion, it probably shouldn't be a Notice. I haven't viewed the whole context of the page, but your suggestion to just use gray text seems good to me.

Was this page helpful?
0 / 5 - 0 ratings