Wp-calypso: Comments: M4 performance profiling

Created on 20 Nov 2017  路  9Comments  路  Source: Automattic/wp-calypso

  • [x] Let's do a profiling pass to make sure that we're not rendering Comment components unnecessarily
    (https://github.com/Automattic/wp-calypso/pull/20098)
  • [ ] Verify that a comments-tree call on a large site >150k comments is not prohibitively slow.

Also see: https://reactjs.org/docs/optimizing-performance.html#profiling-components-with-the-chrome-performance-tab

We can profile in Chrome or FF using the timeline:
https://developers.google.com/web/tools/chrome-devtools/evaluate-performance/reference
https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Profiling_with_the_Built-in_Profiler

Comments [Pri] High [Type] Task

Most helpful comment

Sorry for not giving a heads up, I missed this issue. :(

All 9 comments

@Copons already started a PR to address the first point: https://github.com/Automattic/wp-calypso/pull/20098

Sorry for not giving a heads up, I missed this issue. :(

Note that folks are still seeing slow script warnings in FF.

I left a comment on the project master thread that has a video showing some of the areas that feel sluggish when using the current iteration.

I think that sluggishness is caused by too many network requests.

We have an issue for the comments tree response caching, which might help us here: https://github.com/Automattic/wp-calypso/issues/19045

But we might actually need to add a new "freshness" behaviour on the QueryComment component.

Noting a user complaint here.

Thanks @supernovia!

@supernovia Thanks for reporting!
I'll make sure to read it all first thing tomorrow, but meanwhile you can tell them that the comments section is in active development and we're working on it as we speak. 馃檱

With #21155 in, I think we can close this out for now.

Was this page helpful?
0 / 5 - 0 ratings