Wp-calypso: DevDocs: ReaderFullPostHeader missing styles

Created on 31 Oct 2017  路  3Comments  路  Source: Automattic/wp-calypso

Steps to reproduce

  1. Starting at URL: https://wpcalypso.wordpress.com/devdocs/blocks/reader-full-post-header
  2. Compare the block's style to an actual full post header in the Reader

What I expected

The block style as seen in the Reader and previously in the DevDocs (per our visdiff tests):

screen shot 2017-10-31 at 4 26 05 pm

What happened instead

The block is missing its style in the DevDocs:

screen shot 2017-10-31 at 4 26 17 pm

Context / Source

automated-testing #visdiffs

DevDocs Reader [Type] Bug

Most helpful comment

I think we could just declare a section for Devdocs, and create a bundle that imports all the other CSS bundles

Sounds like the best option for the moment - thanks @stephanethomas!

@jeremeylduvall is working on #18921 which will eventually offer the ability to specify multiple CSS bundles for a given section.

As a bonus, it would be so nice if we could specify 'all' to load all known CSS bundles (so we don't have to maintain the list for Devdocs).

All 3 comments

This is an interesting side-effect of CSS splitting, namely https://github.com/Automattic/wp-calypso/pull/19147.

@stephanethomas is it possible to load all stylesheets for Devdocs?

Haha, I didn't envision that particular use case.

Yes, I think we could just declare a section for Devdocs, and create a bundle that imports all the other CSS bundles. Tangentially related, @jeremeylduvall is working on https://github.com/Automattic/wp-calypso/pull/18921 which will eventually offer the ability to specify multiple CSS bundles for a given section.

I think we could just declare a section for Devdocs, and create a bundle that imports all the other CSS bundles

Sounds like the best option for the moment - thanks @stephanethomas!

@jeremeylduvall is working on #18921 which will eventually offer the ability to specify multiple CSS bundles for a given section.

As a bonus, it would be so nice if we could specify 'all' to load all known CSS bundles (so we don't have to maintain the list for Devdocs).

Was this page helpful?
0 / 5 - 0 ratings