Wp-calypso: Reader Conversations: Add Follow Conversation button

[jancavan]

We've now added the Follow(ing) Conversation icons to the Gridicons set in: https://github.com/Automattic/gridicons/pull/246

Next step are:

1. Add a "Follow(ing) Conversation" button in the popover:

We should also update "Follow" to "Follow Site" to avoid confusion of what you're following.

1. Add a "Follow(ing) Conversation" button opposite the Comments header in fullpost:

[fraying]

@jancavan This is perfect. Thank you!

Only one note: In the mockups, when the link is green and says "Following Conversation," you've got the bubble/plus icon showing. I think you meant to use the bubble/check version, yes?

[fraying]

One question: In the Fullpost version, after the "Follow Conversation" link is clicked, should we prompt the user to go to Conversations somehow?

We don't do this when a user follows a site in Reader, but all they have to do is go back to the top of Reader to see what they followed. For a Conversation, they have to know to go to Conversations.

I wonder if, after clicking "Follow Conversation," we should prompt the user with a link to visit Conversations. Maybe in a bubble, similar to the way we do it on the frontend?

Just noting this as a thing to think about. cc @jancavan

[jancavan]

I think you meant to use the bubble/check version, yes?

Yes, good catch. Updated!

I wonder if, after clicking "Follow Conversation," we should prompt the user with a link to visit Conversations. Maybe in a bubble, similar to the way we do it on the frontend?

Good idea. So something like this when they're in fullpost:

When they follow from the popover, we show a bubble that animates into place. We won't be able to do this on mobile though so perhaps we can just use the global notice component for that.

And I think maybe after 3 convos or so (?), we no longer show the popover and we can switch to a global notice component.

[fraying]

@jancavan Love it. 👍

[bluefuton]

One last thing to decide here: how we allow users to mute conversations shown in Conversations that they aren't explicitly following.

Do we just show the 'Following Conversation' button for every post as if they were following it?

[jancavan]

Do we just show the 'Following Conversation' button for every post as if they were following it?

@bluefuton Yes, the button in the ellipsis should be green if they are following it, regardless if they had explicitly clicked on the button or if they're following it because they had Liked or Commented on that post.

If they want to "mute" it, they should just unfollow the conversation.

[bluefuton]

Yes, the button in the ellipsis should be green if they are following it, regardless if they had explicitly clicked on the button or if they're following it because they had Liked or Commented on that post.

Makes sense. We can do that quite easily in Conversations itself, but outside of Convos, we don't actually know what the implicitly followed conversations are, so the button status might be wrong :/

[samouri]

@bluefuton: can we close this in lieue of a more specific issue regarding correct follow status?

[bluefuton]

@samouri sure! I'll create one now 👍