Wp-calypso: Action required: Greenkeeper could not be activated 🚨

[greenkeeper[bot]]

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because we are using your CI build statuses to figure out when to notify you about breaking changes.

Since we did not receive a CI status on the greenkeeper/initial branch, we assume that you still need to configure it.

If you have already set up a CI for this repository, you might need to check your configuration. Make sure it will run on all new branches. If you don’t want it to run on every branch, you can whitelist branches starting with greenkeeper/.

We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

Once you have installed CI on this repository, you’ll need to re-trigger Greenkeeper’s initial Pull Request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper integration’s white list on Github. You'll find this list on your repo or organiszation’s __settings__ page, under __Installed GitHub Apps__.

[ockham]

Since this was brought up in Slack today, is this something you could help with, Flow peeps? @rachelmcr @hoverduck @alisterscott You probably know your way around CircleCI better than I do 😄

[ockham]

(Also asking to make sure this isn't going to break anything, e.g. by inadvertently running costly test on every commit or something like that.)

[hoverduck]

I _think_ the breakdown here isn't that we don't have commit statuses turned on, but rather that CircleCI is set to only run against branches that have a PR associated. Here's the CircleCI run for the greenkeeper/initial branch - https://circleci.com/gh/Automattic/wp-calypso/62020

I'd be worried about flipping that setting back to build on _every_ commit. I don't have any idea how often people are pushing commits to GitHub without having an open PR, but it would mean that we'd start running the CircleCI tests against each one of them.

Although the worst thing that could happen here is that we just flood the CI job queue and slow down the actual test runs. It won't charge us any more money. So we could always turn it on and see what happens, then flip it back. (Maybe ask in #calypso or on the P2 first to see if anyone has any other concerns first?).

It may be worth investigating more on the Greenkeeper side, too. The first question in their FAQ implies that it _should_ be opening a PR and not just a standalone branch. Maybe there's another setting to flip on that side, or an update they've made since this was pushed back in August?

Another option would be something like a cron that scans for greenkeeper/* branches periodically and initiates the build via the API.

[ockham]

Let's look at this again once we've upgraded to React 16.

[blowery]

I turned on builds for all commits in circle CI. Most PRs are just one commit or are added to over time, so I don't think it'll have much impact. Keeping an eye on it none the less.

[blowery]

Also removed the Greenkeeper integration and readded it. Fingers crossed we get another initial PR.

[blowery]

Hmmm.. my way of rejiggering the integration settings may not have worked. I think we may need an Automattic org admin to play with https://github.com/organizations/Automattic/settings/installations/44477

Or I just need to be patient and wait 30 minutes.

[ockham]

Looks like it generated the initial PR successfully now: #25001

[blowery]

OK, a proposed plan:

• mod their initial PR and remove all of the major semver moves. It's just too much to test.
• work in greenkeeper-lockfile
• leave the minor and patch moves and see if calypso flies
• if yes, hurray, merge
• if no, remove all of the minor semver moves
• see if calypso flies
• if yes, hurray, merge
• if no, sigh.

[blowery]

landed the initial greenkeeper PR