Wp-calypso: Reader Conversations: omit pingbacks/trackbacks

Created on 4 Aug 2017  路  10Comments  路  Source: Automattic/wp-calypso

Original https://github.com/Automattic/wp-calypso/issues/16316

This issue can be closed when trackpacks/pingbacks are no longer in the Reader Conversations stream.

Reader [Type] Enhancement

Most helpful comment

Thanks, @aaronyan! Nice work. 馃憤

All 10 comments

We'll need to drop them from the API / last_comment_date consideration too...

@aaronyan

I think this is done! Safe to close, @blowery ?

@fraying: theres more work till this can really be closed:

  1. API should skip them as well (that the cc @aaronyan bit)
  2. In case for whatever reason the API borks and we get ineligible comments we should really fetch more comments so we can still display 3

Ok, thanks, @samouri. Leaving this open until those two things are done.

Still seeing the occasional trackback in Convos.

screen shot 2017-08-28 at 2 42 32 pm

This is the post: https://wpcalypso.wordpress.com/read/blogs/51862805/posts/10958

cc @samouri

we removed trackbacks...but then they came back when we added in update acceptance. all the relevant code is very much in constant flux right now.

we'll have a smarter pingback/trackback removal coming soon

Where's this stand @samouri, @aaronyan ?

@blowery:

  1. api end still needs to filter it out afaik but i may not be up to date on that (@aaronyan)
  2. we still need to implement selectors that can take and respect a filterBacks

Removed pingback/trackback from Conversations API in changeset 162790.

cc: @blowery, @samouri.

Thanks, @aaronyan! Nice work. 馃憤

Was this page helpful?
0 / 5 - 0 ratings