Wp-calypso: Disconnected Jetpack Sites require sites list cleanup

[rickybanister]

@kellychoffman reported to me that she attempted to disconnect a Jetpack site from Calypso via the proper disconnect flow. After doing so she saw this:

I believe that is recent work done by @enejb to help us clean up inactive Jetpack sites.

The thing is, we explicitly, without any doubt, know that Kelly's site should not appear in the sites list.

Did recent work by Enej introduce a bug or do we not yet have a smart check to pro-actively clean up the sites list after a disconnection?

cc @beaulebens @gititon @roccotripaldi

[kellychoffman]

FWIW, when I left the site and revisited, I couldn't find the Jetpack-disconnected site in the site list.

[roccotripaldi]

I can reproduce. Not sure what triggered this regression, but i will work on a fix first thing tomorrow.

[roccotripaldi]

After some digging today, I'm finding that this is only happening with sites that are no longer accessible. Do you recall if that was the case with your site @kellychoffman ?

My current theory is that when the site is inaccessible, something goes wrong on the API where you are not immediately removed from the site.

[kellychoffman]

Yes, that was the case when I initially discovered it.

[designsimply]

(Out of curiosity) what is the expected behavior when an inaccessible Jetpack site disconnected in this flow?

[roccotripaldi]

It should just disappear when you click the button. Also, we have now have maintenance routines that should automatically remove them. So the appearance of inaccessable sites should be less frequent.

[stale[bot]]

This issue has been marked as stale and will be closed in seven days. This happened because:

• It has been inactive in the past 9 months.
• It isn't a project or a milestone, and hasn’t been labeled `[Pri] Blocker`, `[Pri] High`, `[Status] Keep Open`, or `OSS Citizen`.

You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation.

[roccotripaldi]

I'm 95% sure this is fixed. I can no longer reproduce. Let's re-open if it re-surfaces.