Wp-calypso: New Write: Preview: SEO: Reader preview needs updating

Created on 10 Mar 2017  路  6Comments  路  Source: Automattic/wp-calypso

In the new writing experience, when previewing SEO for Reader, it's currently busted.

screen shot 2017-03-10 at 11 04 45 am

Looks like it uses our old class names and structure. It should match current Reader styles, like this:

seo-fixed

This might help? https://github.com/Automattic/wp-calypso/blob/master/client/blocks/reader-post-card/index.jsx

ccing @blowery & @bluefuton for Reader context
ccing @roundhill & @dmsnell because I think they're working on this?

Posts Reader [Type] Bug

Most helpful comment

I started fixing this yesterday, I think it's looking pretty good. Will start a PR soon: https://github.com/Automattic/wp-calypso/tree/fix/12024-seo-reader-preview

All 6 comments

Ah, yes I thought this would happen someday. I think we were waiting on reader-post-card to be created but forgot to check back on it.

@gwwar did the updates in related work and mentioned that she planned on back-porting to here

Thanks, so far it doesn't seem _too bad_ to port this over to use the reader-post-card. It needs a few properties added to the post object to get it looking right.

did the updates in related work and mentioned that she planned on back-porting to here

Oh Stark is currently working on social media shares, but not any reader views. I think the glitch here is that the excerpt isn't stripping markup

@blowery - can you offer any assistance here?

I started fixing this yesterday, I think it's looking pretty good. Will start a PR soon: https://github.com/Automattic/wp-calypso/tree/fix/12024-seo-reader-preview

Was this page helpful?
0 / 5 - 0 ratings