Wp-calypso: Image Editor: falsely thinks that I made an edit

[davewhitley]

Steps to reproduce

1. Starting at URL: media library
2. Click the pencil icon on an image
3. Click Edit Image
4. Don't edit the image, click Done
5. Open the image back up
6. Restore Original button is shown

What I expected

Not to see the restore button, because I didn't make any edits

Screenshot / Video

[gwwar]

@retrofox did we have an open issue for this one?

At the moment restoring is always an edit, but it uses the original content. So clicking the button will always generate a new file url. Basically we'll need to make some endpoint improvements to handle this case.

See also https://github.com/Automattic/wp-calypso/issues/8082#issuecomment-259214216

[retrofox]

It's not exactly the same issue. I recall that we worked to detect if an image was been modified and according to this enable/disable the Done button. I don't see this behavior now. was it removed or it was never landed?

[gwwar]

Ah thanks @retrofox, I missed step 4.

[gwwar]

Let's investigate if this changed due to one of the new image-editor workflows. If we need to be able to click "Done" without changes in some flows but not others, let's add a new config option or allow you to pass through a custom isDisabled function.

[davewhitley]

Or maybe the Done button is not shown at all, and only appears once an edit has been made. Some more thought might be needed though to account for all of these use cases.

[gwwar]

When selecting a site icon, I believe we always display the editor after selecting an image. It could be the case that the user doesn't want to make any changes if the image is already perfectly square.

[stale[bot]]

This issue has been marked as stale because it hasn't been updated in a while. It will be closed in a week.
If you would like it to remain open, can you please you comment below and see what you can do to get things moving with this issue?
Thanks! 🙏

[davewhitley]

Still an issue.

[davipontesblog]

I am closing this as the classic editor in calypso is being deprecated in favor of the block editor. If needed, please feel free to reopen.