Wp-calypso: Sites: Jetpack site preview from My Sites shows navigation masterbar

[lancewillett]

Steps to reproduce

1. Starting with a Jetpack site connected to WordPress.com
2. Go to wordpress.com and click on My Sites
3. Select the Jetpack site
4. Click the site title to bring up the site preview

What I expected

I expected to see the site preview without the WordPress core adminbar visible at the top.

What happened instead

The WP.com "masterbar" navigation is now visible.

Screenshot

Context / Source

context is #dogfooding #livesharing -- I don't think we should show any toolbars in preview because site owners are liable to click there and get preview-ception rather than breaking out of Calypso preview and doing the actions in a new tab or window.

Note: WP.com sites do not show the masterbar in site preview.

[lancewillett]

A bit similar to #2013

[lancewillett]

@spen How's it going on addressing this one?

[spen]

Completely slipped by me! Sorry I'll make this a priority and tackle it tomorrow & the weekend! :)

[marekhrabe]

We are looking into moving all the preview handling code from dotcom codebase to Jetpack. That will also handle this issue.

[lancewillett]

Re-testing this one today, still seeing the masterbar navigation for Jetpack sites in View Site preview pane. (Safari 10.1.2 on OS X 10.12.6)

[marekhrabe]

@lance are you on Jetpack beta? If not, a regular update (5.3) which includes our code should be shipping Sep 5th

[lancewillett]

Awesome, thanks @marekhrabe. Confirmed on my test site by turning back to latest Jetpack stable:

With Jetpack 5.1 I still see the masterbar in Calypso preview

Now turning on Release Candidate (5.3)

Checking the front-end of the site, it's visible there as expected

Now checking Calypso View Site preview again — gone! Sweet.