Wp-calypso: Store: bug in checkout flow

[rralian]

I was testing out the checkout flow for a premium theme to see if there was a good place for a plans upgrade in that process, and I ran into a fatal error. I opened the console and it looks like we have an unhandled error. Possibly when you have conflicting items in your cart. But the result was that the content of the page never loaded.

I'm not sure where this one lands... maybe @gziolo could point in the right direction? I'm attaching to our current milestone just to track it for now, but hoping store team can steal it from us?

[gziolo]

I'm moving it to Gold backlog. I'm going to work on it today :)

[gziolo]

I was able to reproduce this bug. There are two issues that need to be fixed caused by the fact that as part of business plan you get also unlimited themes:

• [x] when there is a business plan in your cart we shouldn't add any premium theme to the cart (backend patch D1418)
• [x] when there is a premium theme in your cart we should remove it once we add business plan to the cart (backend patch D1415)

In both cases we should display some information to the user.

/cc @breezyskies @peterbutler

[janm6k]

Reviewed and deployed both backend patches. Good job!

[rralian]

Thanks for running with this @gziolo (and reviewing the backend @janm6k)!

[janm6k]

D1415 was reverted, we have missed that it caused removing domains when plan was added :(

[janm6k]

code-D1441 has updated version of the fix.

[janm6k]

code-D1441 deployed again, thanks @gziolo for tests!