Worldcubeassociation.org: Vestigial comment about bootstrap table

[jfly]

Hey @jonatanklosko, could you look at https://github.com/thewca/worldcubeassociation.org/blob/18526dcf901fef414dbb56267240a9dec113d802/WcaOnRails/app/assets/javascripts/application.js#L322-L324? It links to an issue on bootstrap-table that has been closed.

I ran into this when debugging why a link with a data-method on it wasn't actually doing anything when clicked. I tracked it down to this call to e.stopPropagation(), which was preventing the javascript from actually executing. Maybe we should look into a solution to that.

(Apologies for the quick description, I don't have much time to write this issue up. Please reach out to me on slack if this isn't clear.)

[jonatanklosko]

I think the only one reasonable solution would involve changing the library, see this comment for details.

[jonatanklosko]

JFTR this has already been fixed by @jfly (wenzhixin/bootstrap-table/pull/3490). Once new version is released and the gem is updated this commend can go away.

[jfly]

Hopefully dependabot will let us know when the new version is out. Try to remember this issue when that happens!

Also, hopefully https://github.com/bjevanchiu/bootstrap-table-rails isn't abandoned, or else we'll have to switch to using webpack to import bootstrap-table.

[UnsolvedCypher]

We're now using bootstrap-table-rails version 1.11.1.1. Can someone confirm that the issue is fixed?

[jonatanklosko]

As far as I can see 1.11.1 doesn't include @jfly's fix, whereas 1.12.0 does. We couldn't update to 1.12.0 though, see #2880.

[jfly]

It looks like the latest version of bootstrap table doesn't include the fix for https://github.com/wenzhixin/bootstrap-table/issues/2545, because I see 966fb77 show up in https://github.com/wenzhixin/bootstrap-table/compare/1.12.2...develop =(