Wordpress-ios: Quick Start v2: VoiceOver: the completed cells state is not communicated

[designsimply]

Steps to reproduce:

1. Go to Settings > General > Accessibility > VoiceOver and toggle the setting on.
2. Open a site in the app which has Quick Start v2 enabled or create a new site and select the option for quick start at the end of Site Creation (screenshot).
3. Double tap "Completed (x)" to toggle it.
4. Double tap any item that is completed.

Result: the completed cells state is not communicated by VoiceOver. (5s)

^{Tested with WP Internal 12.8.0.201907011 on iPhone 6S iOS 12.3.1.}

_{(internal reference: p77Llu-bQ6-p2 h/t @etoledom)}

[guarani]

@designsimply Is the issue here that the VoiceOver commentary is missing an equivalent to the strikethrough - and therefore, should be something like the following?

Create your site (completed)
Get your site up and running

(Newcomer here, just poking around and came across this open issue.)

[etoledom]

Hey @guarani! - That's right.

As you can see in the video from @designsimply , VoiceOver reads the completed cells as they were not completed. We need to tell VoiceOver to make VoiceOver communicate this state somehow.

[guarani]

Thanks for the confirmation, @etoledom!

I can go ahead and look into appending a (localized) "(completed)" to the accessibility label when quick start tasks are completed - the following part of QuickStartChecklistCell.swift looks relevant:
https://github.com/wordpress-mobile/WordPress-iOS/blob/372c9ed58261354207e65c5d04dc2cfce9e6e07b/WordPress/Classes/ViewRelated/Blog/QuickStartChecklistCell.swift#L26

Does that sound like a plan?

[etoledom]

Sounds good!
Also removing it when it moves to not-completed 👍

[guarani]

Sorry, I neglected this one 😔. I'll get to it after wrapping up my current PR.

[guarani]

Sorry, I neglected this one 😔. I'll get to it after wrapping up my current PR.

I'm freed up now, so gonna tackle this in the coming days. (I hope I haven't held it back - if so, please don't hesitate to give it to someone with more bandwidth.)

I don't have a estimate of when I'll be able to tackle this. If someone sees this and wants to take it on, feel free to reassign.