Wordpress-ios: Login: Can't add current/former Jetpack site to app as self-hosted site after logging in to WordPress.com

[rachelmcr]

Expected behavior

I expect to be able to add any self-hosted site to the app (that meets the app requirements) regardless of whether or not I am logged in to a WordPress.com account. Even if the site used Jetpack in the past or currently uses Jetpack, I expect to be able to log in to the app and use it without Jetpack features.

Actual behavior

If I am logged in to a WordPress.com account, I can't add a self-hosted site that used to be connected to Jetpack or is currently connected to a different WordPress.com account. When I try, I get this message:

Please log out before connecting to a different wordpress.com site

I confirmed that if I log in to the self-hosted site _first_, and then log in to my WordPress.com account, it works. It seems like whatever check is happening in the app is seeing the Jetpack connection for the self-hosted site and blocking my login attempt.

Steps to reproduce the behavior

On the web:

1. Set up a self-hosted site.
2. Install Jetpack and connect it to WordPress.com.
3. Disconnect Jetpack from WordPress.com.

In the app:

1. Log in to WordPress.com.
2. Go to My Sites and try to add the self-hosted site. Result: Error as described above.
3. Log out of WordPress.com.
4. Add the self-hosted site to the app.
5. Log in to WordPress.com. Result: You are logged in to both the self-hosted site and your WordPress.com account.

You can also try the same steps in the app with a site that currently has Jetpack connected to a different WordPress.com account, and see the same results.

Tested on [iPhone XS], iOS [12.2], WPiOS [12.2.0.20190412]

cc @yaelirub

[designsimply]

Possibly related: https://github.com/wordpress-mobile/WordPress-iOS/issues/11505#issuecomment-485567523 cc @diegoreymendez

[darnelldibbles]

Another related issue reported here: https://en.forums.wordpress.com/topic/please-check-your-primary-sites-jetpack-connection-3/?view=all#post-3314109

[yaelirub]

An attempt to fix was PRed: https://github.com/wordpress-mobile/WordPressAuthenticator-iOS/pull/98

[mindgraffiti]

Can confirm, bug was reproducible and was fixed in https://github.com/wordpress-mobile/WordPressAuthenticator-iOS/pull/98. Closing this issue.