Wordpress-ios: Quick Start: Dismiss Notices using clearWithTag

Created on 2 Apr 2019  ·  4Comments  ·  Source: wordpress-mobile/WordPress-iOS

In #11281, we added the ability to dismiss Notices using tags:

ActionDispatcher.dispatch(NoticeAction.clearWithTag(noticeTag))

Using NoticeAction.clearWithTag is preferred to NoticeAction.dismiss. The .clearWithTag helps in avoiding dismissing Notices that the current page _did not create_.

In #11281, we only changed QuickStartTourGuide to use .dismiss. This can be improved to use .clearWithTag.

Quick Start [Type] Enhancement good first issue

All 4 comments

Hi,
Let me try this one. Thanks.

I have made a pull request, and I am wondering if I could have a review/ feedback ...

Thank you, @Reza-Rajabi. We'll look into it.

Removed the ticket assignment as the related PR became stale. Please, feel free to pick this up again, thanks!

Was this page helpful?
0 / 5 - 0 ratings