Wordpress-ios: [Reader > Discover] Header (description) is not localised

Created on 7 Dec 2018 · 8Comments · Source: wordpress-mobile/WordPress-iOS

Expected behavior

The description of the content presented in the Discover section is not localised

img_c12c737cffb8-1

Actual behavior

The text describing what this section is about should be localised

Steps to reproduce the behavior

On a device setup to a language other than English, navigate to Reader > Discover

Tested on [device], iOS [version], WPiOS [version]

iPhone 6s+, iOS 12.1, WPiOS 11.4

Project Glot Reader [Type] Bug i18n

Source

ctarda

Most helpful comment

I've no objections, but please check with Editorial and get their blessing first as Discover is content they "own".

And if we do remove it, please open an companion issue in the WPAndroid repo, so we can remove it there as well :)

aerych on 9 Jan 2019

👍3

All 8 comments

Regarding this and https://github.com/wordpress-mobile/WordPress-iOS/issues/10619, these are the title and tagline of the Discover blog, so I wouldn't expect them to be localized.

However, Calypso web hides the Discover section in the Reader for non-English account languages, since Discover is only published in English. We could do something similar in the app.

rachelmcr on 19 Dec 2018

@rachelmcr Thanks for your comment. I was about to implement the suggested solution (hiding Discover for non-english locales) but I am a bit concerned about removing something from the app that has been there for a long time and some users might expect to continue being there.

So, just to double check, should I go ahead and remove Discover for non-english locales?

ctarda on 9 Jan 2019

Removing Discover for non-English locales would match web behavior, but I wasn't a part of implementing it in the app Reader and I'm not sure if there were explicit decisions to have it in the app for all locales, or what the design perspective is on this. Paging @aerych @iamthomasbishop for input on that!

rachelmcr on 9 Jan 2019

I agree w/ @rachelmcr – I wouldn't expect a site tagline to be translated, as it is a "user-generated" thing, and also agree that maybe we should remove it (in non-English scenarios) as Calypso does.