Wordpress-ios: Plugins: Include separate links to WordPress.org plugin page and plugin homepage

[rachelmcr]

Expected behavior

When I view a plugin's details in the app, I expect to see two separate links to the WordPress.org plugin page and the plugin homepage.

Actual behavior

I only see a link to the Plugin homepage, and this is inconsistent (sometimes taking me to the WordPress.org plugin page and other times taking me to the plugin homepage).

Steps to reproduce the behavior

1. Install the Hello Dolly plugin on a Jetpack site.
2. Under My Sites > Plugins, select the Hello Dolly plugin.
3. Select "Plugin homepage" and note that you are taken to the WordPress.org plugin page here: https://wordpress.org/plugins/hello-dolly/
4. Go back to the Plugins list and select the Jetpack plugin.
5. Select "Plugin homepage" and note that you are taken to the Jetpack homepage at https://jetpack.com/. There is no link to the WordPress.org plugin page: https://wordpress.org/plugins/jetpack/

Tested on iPhone 6, iOS 11.2, WPiOS 9.1.0.20171220

[elibud]

Pinging the iOS 👑 of 🔌 : @koke

[koke]

this is inconsistent (sometimes taking me to the WordPress.org plugin page and other times taking me to the plugin homepage)

Hello Dolly is working as expected, it's homepage is set to https://wordpress.org/plugins/hello-dolly/, so we don't show the WordPress.org link because it would be the same.

Jetpack should be showing both though, I'm investigating that

[koke]

Ah, I disabled directory links until we implement checking if a plugin is in the WordPress.org directory (we don't want to show a link to a plugin that doesn't exist).

@jklausa will likely take care of this as part of plugin browsing.

[elibud]

So we are showing whatever link the author listed as the plugin homepage for now, is that correct?

[koke]

Yes, that's the only thing we're displaying for now

[designsimply]

Tested and confirmed with iPhone 6S, iOS 11.2.1, WPiOS 9.1.

[stale[bot]]

This issue has been marked as stale and will be automatically closed. This happened because:

• It has been inactive for the past year.
• It isn't in a project or a milestone.
• It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`, or `good first issue`.

However, discussion is still welcome! If the issue is still valid, please leave a comment with a brief explanation so the issue can be reopened.

[designsimply]

Re-opening because I re-tested the steps provided using WP Internal 12.0.0.20190311 on iPhone 6S iOS 12.1.4 and found that clicking on "Plugin Homepage" for Jetpack led to https://jetpack.com/ and not https://wordpress.org/plugins/jetpack/ as expected.

@jklausa would this be a quick fix?

[jklausa]

I think this should be _relatively_ quick fix, but I'm not sure — I remember there being something weird about how we extract links from the WP.Org plugin catalogue, since there's barely any API for that and I think we had to do some weird HTML scrapping thing — so it's probably a couple hours (I'd say like 1-4) of spelunking.

I'm currently swamped with wrapping up Stats work, but I'd be happy to take a peek after I'm done.

[jklausa]

I took another look at this today and I _think_ I might have misunderstood this ticket earlier.

Right now there are two separate links visible — one labeled "WordPress.org Plugin Page" that leads to https://wordpress.org/plugins/jetpack/ and another one called "Plugin Homepage" that links to jetpack.com.

I think that's the correct behavior here? At least it feels like that????

@designsimply I'm unclear if I there's actually anything to be done here — I think the current behavior makes sense, but I'm open to changes!

[designsimply]

No no, I think you are right I am the one who made a mistake when I tested! I mislead you! 🤦‍♀️

I re-tested and I see just one option showing for Hello Dolly (and as explained above this is the expected behavior) and I see both the plugin page and plugin homepage options working properly for the Jetpack plugin now:

 

_{Tested with WP Internal 12.1.0.20190408 on iPhone 6S iOS 12.2}

[jklausa]

Alrighty then, I think I'm gonna close this one then :)

[designsimply]

Thank you for catching my mistake!