Wordpress-android: Pending drafts local notifications

[develric]

Not sure there is a real issue, but since I will not be able to look into it soon-ish, creating this so it's not lost 😄

Don't think it's urgent so adding it to GK project for now.

Expected behavior

The following is what I understood the feature should look like (so my interpretation of it 😄 )

In Notifications settings, the Notify me on pending drafts flag should deactivate/activate local AlarmManager notifications reminding the user about drafts they created on the app but they didn't promote to Published.

Actual behavior

With that flag on or off I did not get local notifications

Steps to reproduce the behavior

The relevant code is in PendingDraftsNotificationsUtils and NotificationsPendingDraftsReceiver. I reduced on purpose the NotificationsPendingDraftsReceiver.ONE_DAY variable to 60 * 1000 so to accelerate the tests. For completeness I'm not even sure we are using that Notify me on pending drafts anymore (but better to confirm it).

• Create a draft post and save it
• You can check the alarms are scheduled using this adb shell dumpsys alarm | grep -i "org.wordpress.android"
• Wait for the first alarm trigger (60 seconds in my accelerated test)
• Notification was not triggered for me

Tested on [OnePlus 7T], Android [10], WPAndroid [16.9 develop]

[aerych]

See also:
p1615417475001800-slack-android
pcaMk7-rI-p2

[designsimply]

Interesting! I don't feel strongly about the idea of getting notifications in the app about my own pending drafts (as seen in https://github.com/wordpress-mobile/WordPress-Android/pull/4835) and I don't know how many users would like to have that, however, I very much like the suggestion to make it so site admins and editors get notifications for pending drafts submitted contributors or other users.

From what I can see, broken notifications about your own pending drafts didn't get any user response and, in contrast, there have been requests from users who would like to see notifications from contributors pending review. See https://github.com/Automattic/wp-calypso/issues/8556.

[designsimply]

To clarify a bit, my vote would be to remove the current "Notify me on pending drafts" setting in the app in favor of waiting for https://github.com/Automattic/wp-calypso/issues/8556 to be updated and then deciding whether a separate toggle would even be needed in the app for that. It could just be a notification that you get automatically and I'm not sure whether a separate toggle would be needed to turn that specific type of notification on or off. Great discussion point though!