Wordpress-android: Site icon change not working when aborting action

[mzorz]

Expected behavior

Changing the site's icon should either work or show an error if something could not be done or if the process is aborted.

Actual behavior

When aborting a change in the crop tool, you end up with a forever spinning wheel.

Steps to reproduce the behavior

1. tap on my site icon to change the icon
2. accept the dialog
3. choose an image
4. when the crop tool appears, tap the X on the top left to abort the action
5. observe the site's icon shows a neverending spinning wheel instead of showing the previous, unchanged site icon.
6. Also, try tapping on it: nothing happens (so you can't change it anymore).

Tested on [Xaiomi Redmi Note 5], Android [8.1], WPAndroid [alpha-237]

[designsimply]

Good find! Tested and confirmed using WPAndroid 15.5-rc-1 that starting to select an image then exiting the Edit Photo screen using the X results in a spinner that doesn't go away until you leave the My Site section of the app and then go back again. (2m12s)

^{Tested with WPAndroid 15.5-rc-1 on Pixel 3 Android 10.}

[mzorz]

Thanks for confirming and adding screenshots to this @designsimply 🙇