Wordpress-android: Prepublishing Nudges : Publish button for stories cut off on Android 10

[jd-alexander]

Expected behavior

The publish button should be able to the keyboard and navigation bar.
Keyboard closed | keyboard open
--------|-------
|

Actual behavior

The button is cut off by the status bar and keyboard.

Steps to reproduce the behavior

1. Create a story post.
2. Press Publish.
3. See the behavior.

Keyboard closed | Keyboard open
--------|-------
|

Tested on Google Pixel 4 XL, Android 10, WPAndroid wp_alpha2 ()

[wpericam]

Another instance of this reported in zd-3607193

[jd-alexander]

Thanks for reporting @wpericam I will look into this.

[reginabally]

Another report in 3638952-zen with a video recording attached in the ticket.

Device: Xiaomi Redmi Note 9 Pro ( India )
OS: Android 10
App version: WPAndroid 16.3

[jd-alexander]

Thanks for reporting @reginabally we are looking into this issue.

[jd-alexander]

I am thinking that the issue might be occurring because a 1-second delay or so might be needed to catch the keyboard opening on this specific device. The problem is I don’t have any immediate way to verify this. I am seeing where some peeps in the mobile division have Xiaomi devices, so I will try my best to reproduce it on the devices I own and if that's not possible, I will seek another way to address this.

cc @mzorz

[mzorz]

I am thinking that the issue might be occurring because a 1-second delay or so might be needed to catch the keyboard opening on this specific device.

Is there a way we can identify the device model and use something like a map of models -> delay amount in ms? I'm not a fan of having specific behavior but this seems a good enough reason to have something like that (also a map would look a bit more elegant than a hardcoded value anyway). What do you think about that?

The problem is I don’t have any immediate way to verify this. I am seeing where some peeps in the mobile division have Xiaomi devices

For the record I tested on a Redmi Note 5 here and I couldn't reproduce

[jd-alexander]

Is there a way we can identify the device model and use something like a map of models -> delay amount in ms? I'm not a fan of having specific behavior but this seems a good enough reason to have something like that (also a map would look a bit more elegant than a hardcoded value anyway). What do you think about that?

This is a good idea. In this way, we would only test the delay on Xiaomi devices only without introducing a delay for others. Also, this is a good solution because we are able to roll this out in a release, and then we can let the Happiness Engineers check with the Xiaomi users to see if the issue has been resolved. I am going to do this in a PR and I will add you as a reviewer.

For the record I tested on a Redmi Note 5 here and I couldn't reproduce

Thanks again for checking this. I appreciate it.

[jd-alexander]

I created a PR to fix this issue as I observed it on Android 11. I am going to keep investigating how/why it would occur on Android 10 as well if it has something to do with how the window inset API operates on different devices/manufacturers.

[mzorz]

Didn't intend to close this issue, although I did intend to merge this PR https://github.com/wordpress-mobile/WordPress-Android/pull/13948. @jd-alexander let me know if this issue should indeed be closed 🙏 thanks!

[jd-alexander]

Didn't intend to close this issue, although I did intend to merge this PR #13948. @jd-alexander let me know if this issue should indeed be closed 🙏 thanks!

Thanks @mzorz I am thinking we could probably leave it open as I am not totally sure if this issue fixes it on Android 10 I know that there have been times when Android versions have had minor versions, eg. O_MR1 but my investigation so far has not pointed me to this occurrence with version Q. Since this error was also taking place on Xiaomi devices, it could be the case, but the only way to find out is to wait until this fix has been released in production, and the appropriate monitoring is done from a support standpoint to determine this. This fix will be in the 16.7 release so @wpericam & @reginabally could probably check with the users if they updated to that version when it's deployed to the Play Store and if that resolved the issue. If not I will work on finding another solution 🔍

[reginabally]

Thank you so much for the update @jd-alexander! I've reached out to the users in 3607193-zen and 3638952-zen and updated them on the status. We'll report back if the users are still having trouble after updating the app to version 16.7.