Wordpress-android: "Switch Site" text cut off in the header on My site if the device font size is set to Large or Largest

[SiobhyB]

The "Switch Site" text is slightly cut off at the bottom on my device, using alpha-220. Here's a screenshot of what it looks like for me:

Steps to reproduce the behavior

• Log into any account with multiple sites.
• Navigate to the My Sites tab and view the "Switch Site" text.

@rezzap, @donalirl, and @kriskorn, didn't see the issue on their Android devices, but they're running on 14.7 while I'm on the alpha. Here's what the text looked for Kris (running on OxygenOS 9.0.11):

Tested on Pixel 3, Android 10, WPAndroid alpha-220

[rezzap]

Just clarifying that I DID see the same issue on my Samsung Tab A in version 14.7-rc-3

[designsimply]

Strange! I don't see the same problem on my Pixel 3 Android 10 device. I tested several versions of they app by way of apk files from the releases page.

14.8-rc-3|alpha-220|alpha-221|alpha-221 Dark|alpha-221 Light
---|---|---|---|---
||||

^{Tested with WPAndroid 14.8-rc-3, alpha-220, alpha-221 on Pixel 3 Android 10 using WordPress.com Blogger and WordPress.com Free .blog sites.}

🤔 Let me do one more check on this and if we can't see it in our own testing then I think I'd like to close this issue until it comes up again in a beta or production release. Thank you for the report @SiobhyB!

[designsimply]

Got it! It happens when font size is set to large or largest. h/t @theck13

Steps to reproduce:

1. On the device, go to Settings > Display > Advanced > Font size and change it to "Largest."
2. In the app, go to My site and check to see if the "SWITCH SITE" text is cut off in the header.

Result: "SWITCH SITE" text is clipped in the header on the My site page if the device font size is set to Large or Largest.

Default font size|Largest font size
---|---
|

^{Tested with WPAndroid 14.8-rc-3 on Pixel 3 Android 10.}

[designsimply]

You can see that the SWITCH SITE is not exactly centered vertically even with the default text size. That suggests it’s some layout issue or related to padding, margin, etc.

^{h/t @theck13 for the tip and screenshot.}

[khaykov]

@develric @+id/switch_site is using hardcoded height (I think I just copied it from before when doing IA v1). Switching it to wrap_content should do the trick.

[develric]

Hi @khaykov , thanks for sharing 🙇‍♂️! Going to create a quick PR for this later and if you can I'll ask for your review.

Re the following:

You can see that the SWITCH SITE is not exactly centered vertically...

I think that was intentional since there are explicit margin set.

[theck13]

For the button:

• top/bottom _padding_ match
• start/end _padding_ match
• top/bottom _margin_ can differ
• start/end _margin_ match.

[develric]

Hi @theck13 👋! Thanks for the above 🙇‍♂️! Yep that seems to be what we have here with:

android:layout_marginTop="@dimen/margin_medium"
android:layout_marginBottom="@dimen/margin_extra_extra_medium_large"

and the other parameters that match.

So I think it sounds good to keep; let me know in case you have different advise 🙇‍♂️.