Wordpress-android: Commenter usernames are clickable but don't always do something.

[charliescheer]

This issue was brought up to me in this ticket https://woothemes.zendesk.com/agent/tickets/1296133

Essentially what is happening is that if you are in the reader and you look at the comments for a post, all of the comments will have a username of some sort. All of these commenter usernames are tappable, but if there is no site attached to that username the tap does nothing, so it feels like it isn't working. Is there a way we could flash an alert or something, so that when these are tapped on there is some feedback?

I created a quick video of what I am seeing
https://charlietestsiteblog.files.wordpress.com/2018/07/2018_07_26_13_07_21.mp4

Steps to replicate:

1. Go to the reader and find a post with comments on it, tap on the comment bubble.
2. Tap on the usernames of the commenters, if there is no site associated with the user nothing will happen.

[mzorz]

Verified the issue as per the video up here.

This is the place where we need to look into and do something when there is no blog to preview
https://github.com/wordpress-mobile/WordPress-Android/blob/develop/WordPress/src/main/java/org/wordpress/android/ui/reader/adapters/ReaderCommentAdapter.java#L246-L259

[nbradbury]

Rather than alert the user when there's no attached site, I'm thinking we could simply use color to denote which usernames are clickable. We should also disable unclickable usernames so the background ripple doesn't appear when tapped.

[nbradbury]

Digging into this deeper, I'm not seeing any comments that can be tapped. Our code makes comments tappable if there's an author site ID, but sniffing the response it appears that the author site_ID is missing.

Update: I pinged the reader team about this on their P2. This needs backend work before it can be resolved.

[nbradbury]

I'm un-assigning myself from this as my groundskeeper week is ending and the backend work hasn't been done.