Wire: String:replace("","") always returns an empty string

[CSGKCJDBCPQ2K8]

Title says it all really, heres some sample code anyway.

@name Rep Test
print(">"+"Hi":replace("",""))

[thegrb93]

Empty string matches any character. Try string.find("hello","")

[bigdogmat]

Empty string matches any character. Try string.find("hello","")

Why is this relevant? Only reason this returns an empty string is because here we return an empty string if given an empty needle.

That check can be removed as it won't crash anymore. Or it could be changed to just return the string itself, would do the same as calling string.Replace except skips that step.

[CSGKCJDBCPQ2K8]

Strange that "" matches anything, do you think we could get it to just return the input as techically replacing any char with itself should't change anything.

[TomyLobo]

https://github.com/wiremod/wire/blob/master/lua/entities/gmod_wire_expression2/core/string.lua#L313-L317
This is an anti-crash feature.

[bigdogmat]

@TomyLobo Do you not agree that it still should return itself and not an empty string? Also I've already said that it won't crash anymore,

That check can be removed as it won't crash anymore. Or it could be changed to just return the string itself, would do the same as calling string.Replace except skips that step.

[dvdvideo1234]

@TomyLobo

Can you tell what exactly can crash if this is removed, because I see only а value assign. Moreover. Just a return statement. The interpreter will not even go trough the "this:Replace( needle, new)" statement.

[TomyLobo]

@bigdogmat i was just stating a fact, not implying an opinion.