Wire: Error refreshing a file in text editor after it's been renamed

Created on 17 Oct 2016 · 4Comments · Source: wiremod/wire

Steps to reproduce

Create and save a new file via Editor, keep a file opened.
Find a file you've created in file hierarchy (on the left side), and right click it, and then click Rename to...
Rename a file to something else.
Press the Refresh file button.

Details

When a file is renamed, the editor doesn't seem to update the underlying filename for the opened file.
For example, the following script error is thrown:

Console output:

Erroring opening file: expression2/new-filename.txt

There is a typo in there (Erroring). I have also noticed that there is no stack trace, and no line break at the end of the error message.

Bug Text editor

Source

CaptainPRICE

All 4 comments

How did you get that error message? I tested it just now, and got no error. I renamed the file while having that file opened in a tab, and I was able to use that tab just fine. When I saved that tab I had opened, however, it saved it as the old file path (which is fine and could be considered intended behavior, since this is how most editors handle this, like for example sublime text 3).

I have prepared a small snippet of code which will go through all opened tabs and check if any of them have the renamed file opened. If so, it'll update their internal path. But like I said, this is not necessary and it might even be more confusing than just leaving it as it is.

If you tell me how to reproduce the error, I can just fix that instead.

Here's the entire updated rename to function with the small change, in case I update my local copy of gmod and overwrite this change (I don't feel this change is worth creating a whole branch for)

self:AddRightClick(self.filemenu, nil, "Rename to..", function()
        local fname = string.StripExtension(fileName(self.File:GetFileName()))
        Derma_StringRequestNoBlur("Rename File \"" .. fname .. "\"", "Rename file " .. fname, fname,
            function(strTextOut)
            -- Renaming starts in the garrysmod folder now, in comparison to other commands that start in the data folder.
                strTextOut = string.gsub(strTextOut, ".", invalid_filename_chars)

                local oldpath = self.File:GetFileName()
                local newpath = string.GetPathFromFilename(oldpath) .. strTextOut .. ".txt"

                local contents = file.Read(oldpath)
                file.Delete(oldpath)
                file.Write(newpath, contents)

                -- Update all references to this file path in currently opened tabs
                local editor = wire_expression2_editor
                if editor then
                    for i=1, editor:GetNumTabs() do
                        local chosenfile = editor:GetEditor(i).chosenfile
                        if chosenfile and chosenfile == oldpath then
                            editor:GetEditor(i).chosenfile = newpath
                        end
                    end
                end

                self:UpdateFolders()
            end)
    end)

@AbigailBuccaneer thoughts?

Divran on 12 Nov 2016

A git branch is very light-weight. Don't be afraid to create one, even if it's just for showing things.
It's easier to see a diff of what you actually changed that way