set_fullscreen takes an Option<WindowId>.
However we dont need to make get_fullscreen() return an Option<WindowId> because we can use get_current_monitor() -> WindowId instead.
The window manager (at least on X11) can set the fullscreen state so just remembering the state in winit will not be enough.
The way I'd want to address this is similar to #208, since:
So I'd go with WindowEvent::Fullscreen(Option<MonitorId>). However, I'm not opposed to having the getter as well, though I think it really should return Option<MonitorId>, for consistency with set_fullscreen. That also makes it easier to do dumb stuff with combinators.
Thanks, that all makes sense.
Are there any WMs you recommend for testing this?
Not sure if your asking me directly? I only use i3.
Most helpful comment
The way I'd want to address this is similar to #208, since:
So I'd go with
WindowEvent::Fullscreen(Option<MonitorId>). However, I'm not opposed to having the getter as well, though I think it really should returnOption<MonitorId>, for consistency withset_fullscreen. That also makes it easier to do dumb stuff with combinators.