Winforms: Test errors in Pipelines include Msbuild environment variable names

[hughbe]

See https://dev.azure.com/dnceng/public/_build/results?buildId=607683&view=ms.vss-test-web.build-test-results-tab

We have $(AgentOsName) in the logs which should be replaced with the real value

[RussKie]

To make it a little more obvious:

[lukas-lansky]

This might be connected to https://github.com/dotnet/arcade/pull/5156. @chcosta, @davidfowl, is this behavior intended? Do winforms need to pass the arguments explicitly now in the same way aspnetcore does? Or maybe this is already being fixed in https://github.com/dotnet/arcade/pull/5171 by @anurse?

[davidfowl]

Yes https://github.com/dotnet/arcade/pull/5171 needs to be merged asap

[RussKie]

dotnet/arcade#5171 has been merged.

[RussKie]

This is still an issue...

This is from a build run on Jun 1st:

https://dev.azure.com/dnceng/public/_build/results?buildId=666511&view=ms.vss-test-web.build-test-results-tab

[hughbe]

Maybe we're not updated to latest arcade (https://github.com/dotnet/winforms/pull/3369)

[RussKie]

Hmm, I think you may be correct - it was merged 3 weeks ago, but the last we merged an update from arcade was 19 days ago...

[hughbe]

Yes I think that may be why I'm also still seeing the Write-PipelineTelemetryError: not a valid identifier errors that were mentioned in https://github.com/dotnet/arcade/pull/5388#discussion_r431737627

[RussKie]

With #3369 merged, presume it fixed (second time lucky 😄).
Will re-open, if it's still not fixed.