Winforms: [Loc]The text for OK and Cancel buttons is not completely localized or is localized differently compared to Desktop Framework in warning dialog

[zsd4yr]

[zsd4yr]

PropertyGridView.ShowFormatExceptionMessage(string propName, object value, Exception ex) makes use of PropertyGridView.get_ErrorDialog() which creates a new GridErrorDlg if there is not one yet.

The constructor for GridErrorDlg makes use of SR to set the okay button and cancel button text

okBtn.Text = SR.ExDlgOk;
cancelBtn.Text = SR.ExDlgCancel;

[zsd4yr]

I have confirmed that ExDlgOk is not translated for _any_ language

[zsd4yr]

I have confirmed that ExDlgCancel is translated for _all_ languages, but if these translations are different than the Framework translations, than someone with native understanding of the languages should decide which is better. I don't think parity trumps understanding here. If the new translation is better, then we should keep it.

[zsd4yr]

@vivmishra @janbaltus @v-zbsail Who is in charge of these two issues?

• Should I mark in source the OK entries as state="untranslated" or something?
• What about the difference in translation of Cancel?

[dreddy-work]

"OK" string earlier was translated but not now. I won't see any reason why we can;t do it now. @zsd4yr , can you check of "OK" string is translated for any other dialog?

[zsd4yr]

"OK" string earlier was translated but not now. I won't see any reason why we can;t do it now. @zsd4yr , can you check of "OK" string is translated for any other dialog?

I am saying that the string is not translated in the xlfs

[lukaschal]

TRK button "OK" localized now in a xlf file.

File: System.Windows.Forms\src\Resources\xlf\SR.xlf
ID: 0; "ExDlgOk"
SRC: OK
TGT: Tamam

[zsd4yr]

@vivmishra what do we want to do about places where translations differ between desktop fx and core?

[vivmishra]

We should get it reviewed by loc team at a minimum so that we are not introducing bugs.

[lukaschal]

String mentioned below is localized in a NetFX_Dev1 and NetFXRel1, but for now not occurs in a dotnet_winforms localization resources.

File: Localized\ENU\System.Drawing.dll
ID: 0; "TextParseFailedFormat"
SRC: Text "{0}" cannot be parsed. The expected text format is "{1}".
TGT: {0} metni ayrıştırılamıyor. Beklenen metin biçimi: "{1}".

[weltkante]

@lukaschal I think System.Drawing is not part of WinForms, its part of corefx and lives in a separate repository.

[janbaltus]

@vivmishra we are able to fix the OK and Cancel issue, but not the untranslated issue for source (SRC: Text "{0}" cannot be parsed. The expected text format is "{1}".) as this is located in corefx which is now with no loc support.

[janbaltus]

OK translation issue fixed with PR https://github.com/dotnet/winforms/pull/1022/files

[Jessie-Zhang01]

Verified in .Net Core SDK 3.0.100 Preview6 latest build 3.0.100.12103 from Master branch. This bug is fixed.