Windowsserverdocs: Incorrect Contributor Info on Article

[EisenbergEffect]

Updating Issue Description

The published page is displaying incorrect contributor info for this article:

https://github.com/microsoftdocs/windowsserverdocs/blob/master/WindowsServerDocs/manage/honolulu/deployment-guide.md

This may be a docs publishing platform bug. Exploring...

[dend]

@EisenbergEffect it is published, though. This repo runs out of the master branch, not live like others (this branch does not exist here). Compare the contributions from Rafael and you will notice that those are on the site.

[EisenbergEffect]

I wasn't aware that was even possible. In my understanding, live is required. The other publish issue, I was able to validate that content was not present on the site.

[dend]

@EisenbergEffect yep, some teams skip the middle validation. I wonder if this has anything to do with how the commit conflicts were potentially resolved (if any) that might've caused Git history rewrite. Although it does show everything in the Git tree, so something is amiss.

[EisenbergEffect]

Note, the contributors displayed do match the publish date. The publish date does not match master either.

[EisenbergEffect]

Is this a private/public repo pair?

[dend]

The publish date is being picked up from metadata @EisenbergEffect

[EisenbergEffect]

Notice the discrepancy between the updated_at and ms.date.

[EisenbergEffect]

😆

[dend]

@EisenbergEffect yep, see above. I think that's because whoever is updating the article has to manually change ms.date and they did not do so here.

[EisenbergEffect]

Is it possible that the contrib info is retrieved based on ms.date?

[EisenbergEffect]

Another note is that the commit urls are pointing to VSTS. There could be a VSTS/GitHub feature parity issue here as well.

[dend]

@EisenbergEffect good catch. That's the likely problem, since VSTS has no concept of GitHub IDs to link to. This still sounds like a bug that we should track and fix, otherwise it does seem like we are ignoring giving credit.

[EisenbergEffect]

I agree. Let's see what Ying says. We can update this thread based on that.

[brianlic-msft]

There is a public/private pair here and the live branch publishes out of the private repo. VSTS is supposed to pull in the GitHub profile information to show contributors.

[EisenbergEffect]

It looks like there's some on-boarding to a VSTS-related feature on our end that needs to happen. We're following up with engineering.

[riverar]

Any updates on this?

[EisenbergEffect]

@herohua Were you able to pick up this issue related to VSTS/GitHub repo pairing? I think @yunyunyunyun was working on the VSTS parity work items, but I wasn't sure what the status of this was.

[riverar]

Heartbeat: Still broken. 🌵

[brianlic-msft]

@EisenbergEffect were you able to track this down?

[EisenbergEffect]

@herohua can you comment on the above?

[EisenbergEffect]

Also @cillroy can you take a look at this and dig in with @herohua on what's going on here? It's very important that we get any issues regarding correct contributor attribution fixed.

[lizap]

Has this been fixed? And if so, can I please close this issue? In the GitHub source, we see 5 contributors. On the published article, 5 contributor bubbles. In the VSTS repo, the true source for the article, 5 contributors, all of whom are displayed on the published article.

[EisenbergEffect]

Let's close this out. It seems to be fixed. I'll circle back with @herohua internally and double confirm as well.

[riverar]

This is not fixed. Come on guys, all you had to do was load https://docs.microsoft.com/en-us/windows-server/manage/honolulu/deployment-guide and notice my boring face isn't there.

Here's the original PR that Liza resolved, since seems everyone has forgotten
https://github.com/MicrosoftDocs/windowsserverdocs/pull/199

cc: @lizap @EisenbergEffect @brianlic-msft @dend

[EisenbergEffect]

Apologies @riverar Next time I will confirm for myself.

@herohua Can we get this fixed please? It's a bug that's apparently still present after 3 months.

@cillroy Can you help drive any fixes that are needed here? Please escalate this as a top priority fix for S131.

[EisenbergEffect]

Actually, @newyunyunyunyun Can you follow up on this instead of @cillroy This may in fact be a VSTS parity issue. This is high priority.

[riverar]

We're approaching 5 months now on this issue. Just a very friendly thorn 🌵 to keep in everyone's side.

☮️

[dend]

ACK. Raising this with engineering. @riverar

[cillroy]

@riverar this had slipped through the cracks - sorry about that, I was not used to monitoring github comments. Let me follow up with @dend

[herohua]

@riverar , GitHub page (https://github.com/MicrosoftDocs/windowsserverdocs/blob/master/WindowsServerDocs/manage/honolulu/deployment-guide.md) also fails to show up your contribution info. Can you confirm your email address is linked to your GitHub account?

FYI @dend @cillroy

[riverar]

Yes, that's the bug. :)

Mentioned earlier, see https://github.com/MicrosoftDocs/windowsserverdocs/pull/199.

[dend]

@riverar we are currently looking at the source of the problem - likely it was a squash merge, that resulted in losing contribution info. This will help us better craft the policy in the future.

In the meantime, I think we can properly ACK the contribution via an empty PR - if you can open one with a minor file change (e.g. space), that way your name will be associated with the article.

cc: @cillroy @herohua

[riverar]

@dend Done.

[brianlic-msft]

This change should go live in a few hours.

[dend]

@riverar attribution is now properly displayed on the live page:

Apologies once again for the mix-up! We are taking precautions to make sure attribution is preserved in the future.