Windowscommunitytoolkit: GridSplitter accessibility issue reported by Accessibility Insights

[mrlacey]

Describe the bug

The GridSplitter uses a symbol for the handle icon ("\xE784" & "\xE76F") and this is exposed to the automation tools. However, this is not an accessible value and so fails basic accessibility testing.

• [ ] Is this bug a regression in the toolkit? If so, what toolkit version did you last see it work:

Steps to Reproduce

Steps to reproduce the behavior:

1. Add a GridSplittter to a page and run the app
2. Analyze with Accessibility Insights for Windows
3. See error

Expected behavior

Controls should not fail basic accessibility tests

Screenshots

This is what the tool reports. Note that the icon (from 'Segoe MDL2 Assets') cannot be rendered by accessibility software.

Environment

NuGet Package(s): Microsoft.Toolkit.Uwp.UI.Controls

Package Version(s): 6.1.0

Windows 10 Build Number:
- [ ] Fall Creators Update (16299)
- [ ] April 2018 Update (17134)
- [ ] October 2018 Update (17763)
- [ ] May 2019 Update (18362)
- [x] May 2020 Update (19041)
- [ ] Insider Build (build number: )

App min and target version:
- [ ] Fall Creators Update (16299)
- [ ] April 2018 Update (17134)
- [ ] October 2018 Update (17763)
- [x] May 2019 Update (18362)
- [x] May 2020 Update (19041)
- [ ] Insider Build (xxxxx)

Device form factor:
- [x] Desktop
- [ ] Xbox
- [ ] Surface Hub
- [ ] IoT

Visual Studio 
- [ ] 2017 (version: )
- [x] 2019 (version: 16.6.4) 
- [ ] 2019 Preview (version: )

Additional context

The fix is to expose an appropriate automation name/description for this element.

There may be other controls with accessibility issues and I haven't looked at them (yet) but this was found while testing the accessibility of apps generated by Windows Template Studio (X-Ref: https://github.com/microsoft/WindowsTemplateStudio/issues/3723)

[msftbot[bot]]

Hello mrlacey, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

[Kyaa-dost]

Thanks, @mrlacey for the find! Are you already working on a fix?

[mrlacey]

Thanks, @mrlacey for the find! Are you already working on a fix?

can do ;)

[michael-hawker]

Thanks @mrlacey, I'm planning on my stream tomorrow afternoon to attempt the initial refactor of the GridSplitter (based on my ContentSizer control), but I believe the content symbol will work similarly/the same; so I imagine it has the same issue?

Are we just missing an automation property name somewhere?

[mrlacey]

what a dreadful original title - fixed. sorry.

[azchohfi]

Closing, as this is now shipped:
https://www.nuget.org/packages/Microsoft.Toolkit.Uwp.Notifications/6.1.1