Windowscommunitytoolkit: Oddness with Theming and Selection in InfiniteCanvas Control?

[michael-hawker]

Describe the bug

It appears in certain cases with certain app themes (light vs. dark) the selection highlight on the InfiniteCanvas Toolbar isn't appearing correctly. This makes it difficult to understand the current state of a textbox within the canvas. See screenshots below.

• [ ] Is this bug a regression in the toolkit? If so, what toolkit version did you last see it work:

Steps to Reproduce

Steps to reproduce the behavior:

1. Go to InfiniteCanvas sample in Sample App
2. Add a TextBox
3. Make it Bold
4. Change Themes

Expected behavior

Should see blue selection for button in all scenarios/themes.

Screenshots

If applicable, add screenshots to help explain your problem.

From Dev:

From Store:

(Note ignore if you see Italic selected as well, that was fixed as part of #3118.)

Environment

NuGet Package(s): 

Package Version(s): 

Windows 10 Build Number:
- [ ] Fall Creators Update (16299)
- [ ] April 2018 Update (17134)
- [ ] October 2018 Update (17763)
- [ ] May 2019 Update (18362)
- [x] Insider Build (build number: 19592)

App min and target version:
- [ ] Fall Creators Update (16299)
- [ ] April 2018 Update (17134)
- [ ] October 2018 Update (17763)
- [ ] May 2019 Update (18362)
- [ ] Insider Build (xxxxx)

Device form factor:
- [ ] Desktop
- [ ] Xbox
- [ ] Surface Hub
- [ ] IoT

Visual Studio 
- [ ] 2017 (version: )
- [ ] 2019 (version: ) 
- [ ] 2019 Preview (version: )

Additional context

Not sure if this is an Insider or Release build type issue? Is anyone else seeing this?

[msftbot[bot]]

Hello michael-hawker, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

[deanchalk]

I would like to start contributing to this project, can this one be assigned to me .? I can see what the issue is, happy to create a pull request

[michael-hawker]

Welcome aboard @deanchalk! Thanks for offering to pick this issue up. I was on an Insider build with other oddness going on, so it may just be something with that. Do let us know any findings you have, in the meantime I'll leave it in your great hands!

Also, do let us know if you run into any other problems with the InfiniteCanvas while investigating more such as #3178.

[deanchalk]

I have submitted a PR (first one ever, so I hope its ok)

[Kyaa-dost]

@deanchalk Thanks for the PR. I will check it out.

[Kyaa-dost]

Also @michael-hawker I was able to reproduce this in OS Build 18363.720. Good find!