Windowscommunitytoolkit: Can't Remove Light Effect

[seanocali]

I'm submitting a...

Bug report (I searched for similar issues and did not find one)

Current behavior

After using a Light animation, there's no obvious way to remove the effect.

Expected behavior

FrameworkElement.Light(0, 0).Start() would remove the effect. But it only removes the spotlight, not the shadow.

Minimal reproduction of the problem with instructions

await myFrameworkElement.Light(10, 1200).StartAsync(); 
await myFrameworkElement.Light(0, 0).StartAsync();

Environment

Nuget Package(s): 

Package Version(s): 

Windows 10 Build Number:
- [ ] Fall Creators Update (16299)
- [x] April 2018 Update (17134)
- [ ] October 2018 Update (17763)
- [ ] Insider Build (build number: )

App min and target version:
- [ ] Fall Creators Update (16299)
- [x] April 2018 Update (17134)
- [ ] October 2018 Update (17763)
- [ ] Insider Build (xxxxx)

Device form factor:
- [x] Desktop
- [ ] Mobile
- [ ] Xbox
- [ ] Surface Hub
- [ ] IoT

Visual Studio 
- [x] 2017 (version: 15.8.7)
- [ ] 2017 Preview (version: )

[kbrons]

Hi @seanocali, thanks for reporting the issue! Could you submit a reproduction project?

[seanocali]

LightEffectBugRepoApp.zip

[nmetulev]

If I understand this correctly, the ask here is to add a way to remove the visual effect completely? If so, I wonder if it makes sense to add an extensin method to do that?

@JustinXinLiu might have some thoughts on this as well

[JustinXinLiu]

The current Light implementation is dated and will likely be replaced by XamlLight in the future. For the time being, I'd recommend to roll your own.

[nmetulev]

IMO, the current implementation should be deprecated and replaced with an implementation based on XamlLight

[kbrons]

According to the XamlLight documentation, the minimum version supported is the Creators Update. By the current supported platforms of the toolkit, we could already start working on it.

[nmetulev]

@kbrons, could you submit a PR to just deprecate the current light implementation and point developers to XamlLight?

[nmetulev]

Light is now deprecated