Windowscommunitytoolkit: Resolve service dependencies on obsolete HttpHelper class

[cbarkerms]

HttpHelper will become obsolete in v2.0 of the toolkit. We need to remove service dependencies from HttpHelper to HttpClient to prevent a large number of warnings upon building.

[nmetulev]

Also need to update documentation for HttpHelper and mark it obsolete

[Code-ScottLe]

So I assume a bunch of others services are using HttpHelper and we want to change it to HttpClient ?

Also the link to the source code of HttpHelper on the doc is also wrong. I can knock this out tonight or something.

[nmetulev]

ping @hermitdave

Correct, HttpHelper is deprecated and we need to move to using HttpClient.

Thanks @Code-ScottLe

[Code-ScottLe]

Okay, I will get on this tonight. Do you want me to fix the doc along the way or that should be a separate PR?

[nmetulev]

If you can get it in the same PR, that would be preferred.

[Code-ScottLe]

The doc will have to be updated to show that the API is obsolete anyway. Probably cleaner that way (save a PR and potential conflict).

[Code-ScottLe]

Just to make sure, which version of HttpClient are we using? System.Net.Http or Windows.Web.Http (which I assume the former?)

Edit: The error on source code link is on master version of the docs. It was fixed in the dev branch.

[hermitdave]

Folks.. HttpHelper has just been marked obsolete. We don't need to rush moving to (System.Net / Dotnet Standard 1.4) HttpClient just yet. We can see what other services we move to .NET Standard and then move those to using HttpClient rather than HttpHelper

[hermitdave]

if we do then yes please go ahead.

[nmetulev]

My thoughts on this, if we can move to System.Net now, we should do it to make it easier down the line if once me move other services to .NET Standard. The obvious exception being Windows.Web.Http.HttpClient is better suited for a specific service.

[Code-ScottLe]

Most of the transition to System.Net.Http.HttpClient was smooth without much conflicts. I just need a suitable way to test all of the services which we don't have unit tests on (as noted in the PR).

[hermitdave]

With most services, I tested out using the sample app