Windowscommunitytoolkit: Hamburger menu focus indicator incorrect when using keyboard

[Pinox]

Just reporting a bug that i noticed in the UWP sample app. The hamburger menu focus indicator does not update when using the up/down arrow on your keyboard.

Steps to reproduce. Select say "controls" with your mouse in the hamburger menu. Now use your keyboard up/down keys. The focus indicator will move around but will not update unless you press enter.
Not sure what the behaviour should be but say user move around the focus and then press tab , you will essentially move the focus indicator without actually changing the page.

The indicator will then be out of sync with displayed page.

[skendrot]

This is standard ListView behavior. You do not want to select an item just when mousing around. Only when you hit [enter] or [space] should it select

[nmetulev]

While this is a standard ListView behavior, the selected indicator should not move with the focus. The focus rectangles should be able to move across items without selecting them. The issue here is that we are handling the itemclick event, but the selection can change without an item being clicked

[skendrot]

Just tested and I did not realize the selection indicator border moves as well!

[skendrot]

Discussion: Should the menu

1. change when using mouse click and keyboard up/down 👍
2. change when using mouse click and enter/space? 🎉

[nmetulev]

🥇(I couldn't choose this :) )

If i think about how this would work for controller or tab navigation, option 2 makes more sense to me. Otherwise, the way it is used by most apps, I would have to navigate to multiple pages as I focus through each one before I navigate to the page I want.

[skendrot]

Changed the symbol used for option 2

[skendrot]

What is the behavior in the new NavigationView?

[nmetulev]

Just tested it, it's option 2

[skendrot]

Option 2 it is.

I think we may need a new list type like the NavigationView has. Using a standard ListViewItem isn't applying the style when the ListView has a SelectionMode of None

[nmetulev]

Up?

[nmetulev]

Up?

[windowstoolkitbot]

This issue seems inactive. It will automatically be closed in 14 days if there is no activity.

[windowstoolkitbot]

This issue seems inactive. It will automatically be closed in 7 days if there is no activity.

[skendrot]

Should this issue remain open with the new navigation view coming out?

[lucaasrojas]

Hi! What's the current status of this issue?

[lucaasrojas]

Should this issue remain open having the navigation view control?

[nmetulev]

Even though we will eventually remove the HamburgerMenu, I think this issue might be pretty straightforward to fix. @kbrons, would your solution from the MasterDetailsView work here?

[kbrons]

I just tested it and it's working. I'll create a PR.

[nmetulev]

PR merged