Windowscommunitytoolkit: Classic Menu tweeks

[tibitoth]

I have the following requests to the classic menu:

• [x] Slow opening animation at some time:
• [x] ~Add icons to menu items into the left side~ Sorry I missed that MenuFlyoutItem has Icon property. MenuItem does not need to have Icon. Maybe we can add some example of MenuFlyoutItem.Icon to the sample app.
• [x] Add shortcut info to menu items into to right side

anim:

[nmetulev]

ping @IbraheemOsama

Thanks for the feedback @totht91

1. Not sure what you mean by

   Slow opening animation at some time:

   Could you expand?

2. We can easily change the Header of a MenuItem to support any Content and I think we should do that, then you can just do this to add the icon:

   <controls:MenuItem Name="FileMenu"
                      controls:Menu.InputGestureText="Alt+F">
       <controls:MenuItem.Header>
           <StackPanel Orientation="Horizontal">
               <SymbolIcon Symbol="Accept"></SymbolIcon>
               <TextBlock Text="Hello"></TextBlock>
           </StackPanel>
       </controls:MenuItem.Header>
   </controls:MenuItem>
   

3. Tooltips show up under the MenuItems when alt is pressed and released. Did you have something else in mind?

[JohnnyWestlake]

For 3, it's something like this where we should be able to (optionally?) display the keyboard shortcut alongside the content in the menu

[Vijay-Nirmal]

I also notice.

Slow opening animation at some time

Focus Box(Black box) will appear on the MenuItem but MenuItemFlyout only opens after the Focus Box hide. If we move fast then Flyout will not open.

[nmetulev]

I see what you mean, this is something we should take a look at for both 1 and 3. @IbraheemOsama, any thoughts on this?

[tibitoth]

@nmetulev

1. See the two attached gif. Sometimes the menu is not showing immediately.
2. Sorry I missed that MenuFlyoutItem has Icon property. MenuItem does not need to have Icon property. Maybe we can add some example of MenuFlyoutItem.Icon to the sample app.
3. Exactly what @JohnnyWestlake mentioned.

[IbraheemOsama]

Will start working on the tweeks :)

[nmetulev]

PR merged