Windows-itpro-docs: DG_Readiness_Tool_v3.6.ps1 on Non-English OS

Created on 13 Aug 2019  Â·  8Comments  Â·  Source: MicrosoftDocs/windows-itpro-docs

Hey everyone,

no, this is not about the architecture alone. Here are some suggestions that would immensely help working with the readiness tool:

  • Let $path be a param
  • For Non-English OS: Avoid DISM completely. String comparison on Non-English OS will never work. Instead use something like Enable-WindowsOptionalFeature -FeatureName Microsoft-Hyper-V-All or Get-WindowsOptionalFeature -Online | select featurename | where {$_ -like "*Hyper-V*"} (ofc don't use "like" I was just lazy here)
  • For Non-English OS: CheckDriverCompat and all following functions (ListDrivers, ListCIStats, CheckFailedDriver) need to be adjusted to make it work on Non-English OS (see next for an example)
  • For Non-English OS: $verifier_state.ToString().Contains("No drivers are currently verified.") could be !$verifier_state.ToString().Contains("[X] 0x02000000") I do not have a machine to doesn't do code signing rn
  • For Non-English OS: If you already know about the architecture issue and you already fixed this for "CheckOSSKU" why not do this same for "CheckOSArchitecture"?

Why suggest all this? Because I want this to work on every language and I want to have it signed, which should be done by MS. I realize there are many ways to manage and/or activate DG/CG/HVCI, but for testing alone these changes would be worth it. I think the overall quality of the script can be improved be a few adjustments as described.


Document Details

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

security

Most helpful comment

@illfated Yes, I'm fine now - I was actually sick for about 2 weeks now with Influenza B - no fun. If there's anything I can help with (test for example) I'll gladly do so. I have multiple international customers, so I have Windows 10 in a variety of languages at hand.
I'm already really happy this got picked up as quick as it did. Thank you!

All 8 comments

@officedocsbot assign @mypil

@sanso2010 - Thank you for submitting feedback.

I will get this issue over to the Win10 ITPro writing team for investigation.

Thank you for reporting and making the docs better. Much appreciated.

I made a note to request the team to update this when the work is complete.

Ref. #3234

@sanso2010 - The Win10 ITPro writing team is working on getting the fixed script to be published. Please standby for further updates. Thank you for your patience.

Hello everyone.
The script has been updated by the product team behind it, I created a pull request to update the document references, you should be able to see the changes soon.
Thank you

@sanso2010 : Hope to hear back from you again some time. Also hope everything is OK with you.

@illfated Yes, I'm fine now - I was actually sick for about 2 weeks now with Influenza B - no fun. If there's anything I can help with (test for example) I'll gladly do so. I have multiple international customers, so I have Windows 10 in a variety of languages at hand.
I'm already really happy this got picked up as quick as it did. Thank you!

@sanso2010 - From our understanding, the issue has been resolved. If you feel it hasn't been resolved, please re-open this issue.

Thank you for your contribution to make the docs better! Much appreciated!

Was this page helpful?
0 / 5 - 0 ratings